Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.88.0 #5445

Merged
merged 6 commits into from
Feb 4, 2023
Merged

Release 1.88.0 #5445

merged 6 commits into from
Feb 4, 2023

Conversation

jhnstn
Copy link
Member

@jhnstn jhnstn commented Feb 2, 2023 •
edited
Loading

Release for Gutenberg Mobile 1.88.0

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Bump Android minSdkVersion to 24

#5435

Bump Aztec-Android version to 1.6.3

#5438

Update React Native Reanimated to 2.9.1-wp-3

#5430

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

This was referenced Feb 2, 2023
Merged
Merged
Merged
@jhnstn jhnstn requested review from fluiddot and dcalhoun February 3, 2023 16:07
dcalhoun
dcalhoun approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one failing test appears to be infrastructure related, so I believe we should be good to merge.

Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages

@jhnstn jhnstn marked this pull request as ready for review February 3, 2023 18:02
@jhnstn jhnstn enabled auto-merge February 3, 2023 22:06
@jhnstn jhnstn disabled auto-merge February 3, 2023 23:31
@jhnstn jhnstn enabled auto-merge February 3, 2023 23:52
@jhnstn jhnstn disabled auto-merge February 4, 2023 01:39
@jhnstn jhnstn merged commit 49dbab3 into trunk Feb 4, 2023
@jhnstn jhnstn deleted the release/1.88.0 branch February 4, 2023 14:48
@fluiddot
Copy link
Contributor

fluiddot commented Feb 7, 2023 •
edited
Loading

🟢 Writing Flow checklist (iOS)

Device: iPhone 11 (iOS 15.4)
Build: 21.7.0.0 (TestFlight)

General

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

@fluiddot
Copy link
Contributor

fluiddot commented Feb 7, 2023 •
edited
Loading

🟢 Changes included in the release (iOS)

Device: iPhone 11 (iOS 15.4)
Build: 21.7.0.0 (TestFlight)

@fluiddot
Copy link
Contributor

fluiddot commented Feb 7, 2023 •
edited
Loading

🟢 Test Suite 4 (iOS)

Device: iPhone 11 (iOS 15.4)
Build: 21.7.0.0 (TestFlight)

DarkMode - 2

  • Spacer block - Dark mode - TC004
  • Buttons block - Dark mode - TC005
  • Group - Dark mode - TC006
  • Columns - Dark mode - TC007

Group - 2

  • Group - Navigation up button works as expected - TC006
  • Group - Navigation down works according to parent-first approach - TC007
  • Group - Cross navigation between blocks works as expected - TC008
  • Group - Check if in DarkMode all components gets proper colors - TC009
  • Group - Check if nested Placeholder block can be replaced - TC014

Spacer - 1

  • Spacer block - Spacer in horizontal layout works as expected - TC001

Buttons - 4

  • Buttons block - Render custom text color - TC013
  • Buttons block - Render custom background color - TC012
  • Buttons block - Render gradient background color - TC014
  • Buttons block - Check if selection / caret color matches font color - TC016
  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview - TC017

Buttons - 5

  • Buttons block - Edit text styles - TC005
  • Buttons block - Render theme colors - TC015
  • Buttons block - Settings: Change Button border radius - TC011

Buttons - 7

  • Buttons block - Link from the clipboard is presented as an option in the link picker - TC020
  • Buttons block - Toolbar link button is active when Button has link - TC018

Editor Theme - 2

  • Custom Gradients - Check that custom gradients load in the editor - TC004
  • Offline Support - TC005

Color Settings - 2

  • Pressing color swatch - TC004
  • Customize gradient color - TC005
  • Custom color picker - TC006

@fluiddot
Copy link
Contributor

fluiddot commented Feb 7, 2023 •
edited
Loading

🟢 Unsupported Block Editing (iOS)

Device: iPhone 11 (iOS 15.4)
Build: 21.7.0.0 (TestFlight)

Unsupported Block Tests

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@jhnstn
Copy link
Member Author

jhnstn commented Feb 8, 2023 •
edited
Loading

🟢 Writing Flow checklist (Android)

Device: Pixel 6 (Android 13)
Build: 21.7-rc-1

General

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@jhnstn
Copy link
Member Author

jhnstn commented Feb 8, 2023 •
edited
Loading

🟢 Test Suite 3 (Android)

Device: Pixel 6 (Android 13)
Build: 21.7-rc-1

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC004
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Gallery - 4

  • Gallery block - Settings: Link to - TC012
  • Gallery block - Settings: Column number - TC013
  • Gallery block - Settings: Crop images - TC014

Columns - 2

  • Columns - Max limit of Column number - steps
  • Columns - Deep nesting is possible (iOS only)- steps
  • Columns - Check if Column placeholders is visible for the unselected state - steps
  • Columns - Appearance in vertical device position (vertical layout) - steps

Columns - 3

  • Columns - Appearance in horizontal device position (horizontal layout) - steps
  • Columns - Mover direction - steps
  • Columns - Check if Column placeholder is render in nested structure - steps
  • Columns - Unselected Column placeholder is streched to content in nested structure- steps

Columns - 4

  • Columns - Check if in DarkMode all components gets proper colors - steps

MediaText - 3

  • Media Text block - Insert video from device (failing) - TC001-v
  • Media Text block - Close/Re-open post with an ongoing video upload - TC003-v

MediaText - 4

  • Media Text block - Media & Text alignment - TC006
  • Media Text block - Vertical alignment - TC007

Shortcode-1

  • Shortcode block - Add a youtube link - steps

Cover - 2

  • Cover - Add Video Background from WordPress Media library - TC004
  • Cover - Replace media - TC005
  • Cover - Gradient background is rendered properly - TC006
  • Cover - Gradient overlay is rendered properly - TC007

Image - 2

  • Image block - Border style setting - TC006
  • Image block - Image size setting - TC007
  • Image block - Link to setting - TC008

Story block - 1

  • Story block - Verify is available in Block Picker - TC001
  • Story block - Verify is not available in Block Picker- TC002
  • Story block - Add media to empty Story block - TC003
  • Story block - Add media to non-empty Story block - TC004
  • Story block - Close/Re-open post with an ongoing Story upload - TC005

@jhnstn
Copy link
Member Author

jhnstn commented Feb 8, 2023 •
edited
Loading

🟢 Unsupported Block Editing (Android)

Device: Pixel 6 (Android 13)
Build: 21.7-rc-1

Unsupported Block Tests

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@jhnstn
Copy link
Member Author

jhnstn commented Feb 8, 2023 •
edited
Loading

🟢 Changes included in release (Android)

Device: Pixel 6 (Android 13)
Build: 21.7-rc-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

@fluiddot fluiddot Awaiting requested review from fluiddot

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhnstn @fluiddot @dcalhoun