Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.77.1 #4923

Merged
merged 11 commits into from
Jun 3, 2022
Merged

Release 1.77.1 #4923

merged 11 commits into from
Jun 3, 2022

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jun 2, 2022

Release for Gutenberg Mobile 1.77.1

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Change 1

Fixes a crash on iOS related to JSI and Reanimated.

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

@fluiddot fluiddot requested a review from geriux June 2, 2022 11:31
@fluiddot fluiddot marked this pull request as ready for review June 2, 2022 11:31
@fluiddot fluiddot self-assigned this Jun 2, 2022
@fluiddot
Copy link
Contributor Author

fluiddot commented Jun 2, 2022

@fluiddot
Copy link
Contributor Author

fluiddot commented Jun 2, 2022

🟢 Writing Flow checklist (iOS)

Build: pr18812-fc7189e
Device: iPhone 11 (iOS 15.4)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@fluiddot
Copy link
Contributor Author

fluiddot commented Jun 2, 2022

⚪️ Test new changes (iOS)

Build: pr18812-fc7189e
Device: iPhone 11 (iOS 15.4)

I'm not able to reproduce the crash described in #4918, @geriux since you managed to reproduce it, would you mind testing it for me? Thanks 🙇 !

@geriux
Copy link
Contributor

geriux commented Jun 2, 2022

I'm not able to reproduce the crash described in #4918, @geriux since you managed to reproduce it, would you mind testing it for me? Thanks 🙇 !

All good! 🟢 I no longer experience the crash when opening and closing the editor or when rotating to landscape. I did experience another issue, the Don't try to clone an object backed by a different Runtime, but it's not related to this fix. 👍

Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

# Conflicts:
#	bundle/ios/App.js
#	bundle/ios/App.js.map
#	gutenberg
#	third-party-podspecs/FBReactNativeSpec/FBReactNativeSpec.podspec.json
@fluiddot fluiddot merged commit 91a60eb into trunk Jun 3, 2022
@fluiddot fluiddot deleted the release/1.77.1 branch June 3, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants