Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update react-native-reanimated version to 2.4.1 #4653

Merged
merged 20 commits into from
Mar 18, 2022
Merged

Update react-native-reanimated version to 2.4.1 #4653

merged 20 commits into from
Mar 18, 2022

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Mar 14, 2022 •
edited
Loading

Gutenberg PR: WordPress/gutenberg#39430

To test:
Follow the testing instructions from WordPress/gutenberg#39430.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot self-assigned this Mar 14, 2022
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 14, 2022 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot mentioned this pull request Mar 14, 2022
Merged
@fluiddot fluiddot marked this pull request as ready for review March 14, 2022 17:32
@fluiddot fluiddot requested a review from geriux March 14, 2022 17:34
@fluiddot
Copy link
Contributor Author

fluiddot commented Mar 14, 2022 •
edited
Loading

Heads up that I'll wait for version 2.4.1 to be merged and a Git tag creation, before creating the WordPress-Android and WordPress-iOS PRs.

@fluiddot fluiddot mentioned this pull request Mar 15, 2022
Merged
@fluiddot fluiddot linked an issue Mar 15, 2022 that may be closed by this pull request
Update Reanimated library to 2.4.1 #4657
Closed
@fluiddot fluiddot added this to the 1.73.0 milestone Mar 18, 2022
@fluiddot
Copy link
Contributor Author

fluiddot commented Mar 18, 2022 •
edited
Loading

@geriux let me know if you could take a look at this PR, thanks 🙇 ! I'd like to note that as version 1.72.0 has been recently cut, I'm planning to merge the WordPress-Android and WordPress-iOS PRs into gutenberg/after_1.72.0.

geriux
geriux approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested this locally with WordPress iOS app.

@geriux
Copy link
Contributor

geriux commented Mar 18, 2022

@geriux let me know if you could take a look at this PR, thanks 🙇 ! I'd like to note that as version 1.72.0 has been recently cut, I'm planning to merge the WordPress-Android and WordPress-iOS PRs into gutenberg/after_1.72.0.

Sounds good! I'll approve those now.

@fluiddot
Copy link
Contributor Author

Heads up that the Gutenberg ref has been updated when updating with trunk (reference). Since the recent change introduced is just related to E2E tests, I won't generate a new JS bundle for iOS.

@fluiddot fluiddot added the dependencies Pull requests that update a dependency file label Mar 18, 2022
@fluiddot fluiddot enabled auto-merge March 18, 2022 09:40
@fluiddot fluiddot merged commit a4111e0 into trunk Mar 18, 2022
@fluiddot fluiddot deleted the update/react-native-reanimated-2.4.1 branch March 18, 2022 09:59
@geriux geriux mentioned this pull request Mar 31, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees

@fluiddot fluiddot

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
1.73.0 (19.6)
Development

Successfully merging this pull request may close these issues.

Update Reanimated library to 2.4.1
2 participants
@fluiddot @geriux