Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.70.3 #4565

Merged
merged 6 commits into from
Feb 10, 2022
Merged

Release 1.70.3 #4565

merged 6 commits into from
Feb 10, 2022

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Feb 9, 2022 •
edited by fluiddot
Loading

Release for Gutenberg Mobile 1.70.3

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Highlight text: Check if style attribute value is defined during filtering

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

@mchowning mchowning mentioned this pull request Feb 9, 2022
Merged
8 tasks
This was referenced Feb 9, 2022
Merged
Merged
@fluiddot
Copy link
Contributor

fluiddot commented Feb 10, 2022 •
edited
Loading

🟢 Android - New changes

Build: 118821
Device: Samsung Galaxy S20 FE 5G (Android 10)

@fluiddot
Copy link
Contributor

fluiddot commented Feb 10, 2022 •
edited
Loading

🟢 Android - Writing Flow checklist

Build: 118821
Device: Samsung Galaxy S20 FE 5G (Android 10)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@SiobhyB
Copy link
Contributor

SiobhyB commented Feb 10, 2022 •
edited
Loading

🟢 iOS - New changes

Build: 1606
Device: iPhone XR (iOS 15.3)

@SiobhyB
Copy link
Contributor

SiobhyB commented Feb 10, 2022 •
edited
Loading

🟢 iOS - Writing Flow checklist

Build: 1606
Device: iPhone XR (iOS 15.3)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@SiobhyB SiobhyB self-requested a review February 10, 2022 15:49
SiobhyB
SiobhyB approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as we've tested to confirm the release resolves the crash, and didn't uncover any issues in the writing flow.

@fluiddot fluiddot marked this pull request as ready for review February 10, 2022 15:52
@fluiddot
Copy link
Contributor

This PR will be merged into trunk via #4569.

@fluiddot fluiddot merged commit 42e9080 into trunk Feb 10, 2022
@fluiddot fluiddot deleted the release/1.70.3 branch February 10, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluiddot fluiddot fluiddot approved these changes

@SiobhyB SiobhyB SiobhyB approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mchowning @fluiddot @SiobhyB