Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centrally Align Multiline Block Titles in the Inserter #4343

Merged
merged 3 commits into from
Dec 10, 2021

Conversation

mchowning
Copy link
Contributor

Fixes #34748

To test:
Follow the testing instructions for the Gutenberg PR.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@mchowning mchowning requested a review from fluiddot December 7, 2021 14:54
@mchowning mchowning changed the title Update gutenberg submodule Centrally Align Multiline Block Titles in the Inserter Dec 7, 2021
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mchowning I'm wondering if we could an entry for this to the release notes as it's a user-facing change, wdyt?

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mchowning
Copy link
Contributor Author

I'm wondering if we could an entry for this to the release notes as it's a user-facing change, wdyt?

I was wondering about that too, and I don't remember why I didn't do it 😆 .

Do we generally add to the release notes here, just in Gutenberg, both?

@fluiddot
Copy link
Contributor

Do we generally add to the release notes here, just in Gutenberg, both?

Usually, we update both. The main difference between GB-mobile release notes and react-native-editor package changelog is whether the change is user-facing. In the latter, we add any change while in release notes only the user-facing ones.

@mchowning mchowning force-pushed the fix/align-multiline-block-names-in-inserter branch from 57a3388 to 16b3545 Compare December 10, 2021 17:03
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 10, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@mchowning
Copy link
Contributor Author

Added the release notes. Let me know what you think @fluiddot

@fluiddot
Copy link
Contributor

fluiddot commented Dec 10, 2021

Added the release notes. Let me know what you think @fluiddot

LGTM! Thanks for updating the release notes and changelog 🙇 .

@mchowning mchowning merged commit 084f377 into develop Dec 10, 2021
@mchowning mchowning deleted the fix/align-multiline-block-names-in-inserter branch December 10, 2021 18:42
@mkevins mkevins mentioned this pull request Jan 7, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inserter: Block title is not center-aligned
2 participants