Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embed block] - Link in Block Settings #4189

Merged
merged 7 commits into from
Nov 12, 2021
Merged

[Embed block] - Link in Block Settings #4189

merged 7 commits into from
Nov 12, 2021

Conversation

jd-alexander
Copy link
Contributor

Fixes #3887

To test:
Visit WordPress/gutenberg#36099
PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@jd-alexander jd-alexander added this to the 1.66.0 (18.7) milestone Nov 2, 2021
@jd-alexander jd-alexander changed the title Embed block - Link to [Embed block] - Link in Block Settings Nov 2, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 2, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@jd-alexander jd-alexander requested a review from fluiddot November 2, 2021 07:01
@jd-alexander jd-alexander mentioned this pull request Nov 2, 2021
Merged
7 tasks
@fluiddot
Copy link
Contributor

Hey @jd-alexander !
We will cut the 1.66.0 release on 2021-11-11. I plan to circle back and bump this PR to the next milestone then, but please let me know if you’d rather us work to include this PR in 1.66.0. Thanks!

@fluiddot fluiddot modified the milestones: 1.66.0 (18.7), 1.67.0 (18.8) Nov 11, 2021
fluiddot
fluiddot approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#36099 (review).

@fluiddot fluiddot enabled auto-merge November 12, 2021 15:52
@fluiddot fluiddot merged commit f97d742 into develop Nov 12, 2021
@fluiddot fluiddot deleted the issue-3887/embed-block-link-to branch November 12, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluiddot fluiddot fluiddot approved these changes

Assignees
No one assigned
Labels
Embed block [Type] Task
Projects
None yet
Milestone
1.67.0 (18.8)
Development

Successfully merging this pull request may close these issues.

Embed Block - Enhancement: include Link in Block Settings
2 participants
@jd-alexander @fluiddot