Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embed Block] Fix loading glitch with resolver resolution approach #4146

Merged
merged 6 commits into from
Oct 22, 2021
Merged

[Embed Block] Fix loading glitch with resolver resolution approach #4146

merged 6 commits into from
Oct 22, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Oct 21, 2021 •
edited
Loading

Gutenberg PR: WordPress/gutenberg#35798

To test:
Follow testing instructions from Gutenberg PR: WordPress/gutenberg#35798

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added [Type] Bug Something isn't working Embed block labels Oct 21, 2021
@fluiddot fluiddot requested a review from jd-alexander October 21, 2021 09:18
@fluiddot fluiddot self-assigned this Oct 21, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 21, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot mentioned this pull request Oct 21, 2021
Merged
7 tasks
@fluiddot fluiddot added this to the 1.65.0 (18.6) milestone Oct 21, 2021
jd-alexander
jd-alexander approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#35798 (review)

@fluiddot fluiddot enabled auto-merge October 22, 2021 12:43
@fluiddot fluiddot merged commit ea8e176 into develop Oct 22, 2021
@fluiddot fluiddot deleted the fix/embed-block-loading-glitch branch October 22, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd-alexander jd-alexander jd-alexander approved these changes

Assignees

@fluiddot fluiddot

Labels
Embed block [Type] Bug Something isn't working
Projects
None yet
Milestone
1.65.0 (18.6)
Development

Successfully merging this pull request may close these issues.
2 participants
@fluiddot @jd-alexander