Try running UI tests on any updates to develop

[guarani]

Fixes #4101

This PR follows up on the proposal in #4101 to automatically run our full automated test suite on all changes to the develop branch. This is still just a proposal, so the idea of this PR is to try this idea out before we decide on it. If we're happy with it, we can merge this PR to put the proposal into practice.

⚠️ Before merging: If these changes work and are approved, we need to remove the testing branch (this PR's branch) from the config and set post-to-slack to true.

To test

1. Ensure a new Test iOS on Device - Full (On Updated Develop) is seen below under CI checks
2. Ensure a new Test Android on Device - Full (On Updated Develop) is seen below under CI checks

Note: The two new workflows will only run on the develop branch once this PR is merged. They only appear on this PR because we're temporarily adding this PR's branch to the list of branches the workflow runs on.

PR submission checklist:

• I have considered adding unit tests where possible.
• I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

[guarani]

👋 I'm removing the review request since I noticed how Optional UI Tests is still on hold:

[guarani]

👋 Hi @mchowning, this is ready for review again.

There's some repetition in the CircleCI config. For example, ios-device-checks is called three different times and the only difference between them is the name given to the job and the branch the job is triggered on. While it might be worthwhile finding a more concise syntax, CircleCI config will be replaced with Buildkite config in the future, so any optimizations might no longer be necessary.

[guarani]

Thanks for the review, @mchowning! I've addressed the feedback and this should be ready to review again.

[mchowning]

This looks good to me. Thanks @guarani !

There's some repetition in the CircleCI config. For example, ios-device-checks is called three different times and the only difference between them is the name given to the job and the branch the job is triggered on. While it might be worthwhile finding a more concise syntax, CircleCI config will be replaced with Buildkite config in the future, so any optimizations might no longer be necessary.

For merging, would it be cleaner to just remove the two new jobs you created and instead add the develop branch to the "release" jobs and give those jobs a more generic name?

We probably should go ahead and switch from develop to trunk as well since the main apps are making that switch, but that's not an issue that needs to be addressed as part of this PR.

[guarani]

For merging, would it be cleaner to just remove the two new jobs you created and instead add the develop branch to the "release" jobs and give those jobs a more generic name?

That's a good point. I'd considered it in a similar PR (for running these tests on release PRs) but forgot to mention the discussion here. In short, my position was that it would be valuable to have separate names for each. While the Slack notification doesn't show these custom names, clicking on the notification opens CircleCI which displays the job name prominently, which I think is useful. Otherwise you'd need to look at the branch name in the CircleCI job if you wanted to know what type of test was run. I have no strong preference here though, but figured this was the safer option for now. Let me know if you think we should change this in a follow-up PR.

Thanks for the review!

[guarani]

⚠️ Before merging: If these changes work and are approved, we need to remove the testing branch (this PR's branch) from the config and set post-to-slack to true.

I didn't do this before merging, so expect a follow-up PR 🙈
Update: Clean-up will be done in #4224, will request a review on it once its checks have passed.

[guarani]

👋 @mchowning, the clean-up PR and I added you as a reviewer if you don't mind.
Update: Clean up PR merged.