Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Support from inside editor #3975

Merged
merged 20 commits into from
Sep 30, 2021

Conversation

twstokes
Copy link
Contributor

@twstokes twstokes commented Sep 16, 2021

This PR enables developing the feature to contact support from inside the editor for WPiOS and WPAndroid.

To test: Follow instructions in the Gutenberg PR.

Related PRs

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@twstokes twstokes marked this pull request as draft September 17, 2021 15:00
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 17, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@twstokes twstokes changed the title [WIP] Launch support from inside editor [Gutenberg] Contact Support from inside editor Sep 21, 2021
@twstokes twstokes changed the title [Gutenberg] Contact Support from inside editor Contact Support from inside editor Sep 21, 2021
RELEASE-NOTES.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm "approving" this PR to make it clear and yeah, besides updating the Gutenberg hash we'll need to revert the submodule pointer after we get the Gutenberg PR merged.

@twstokes twstokes force-pushed the try/launch-support-from-inside-editor-2 branch from 4659ce0 to 961edcd Compare September 24, 2021 15:52
@hypest
Copy link
Contributor

hypest commented Sep 27, 2021

👋 @twstokes , looks like all feedback has been addressed in this PR and the WP app PRs also got a green light from reviewers so, wdyt about resuming the merge domino? First step in that direction would be to update this PR to point to Gutenberg's PR and the merged (or later) commit. Then we'll smoke test the main app PRs to avoid having something obvious regressed and merge the gb-mobile PR. We'll need to tag the merged gb-mobile state with an -alpha tag to update in the main apps. Let me know if you need me to elaborate on any of that, thanks!

Edit: sorry, upon closer look, there's some pending (design) review on the Gutenberg PR so, let's hold of until @kyleaparker gets the chance to have another pass.

@twstokes twstokes added this to the 1.63.0 (18.4) milestone Sep 30, 2021
@twstokes
Copy link
Contributor Author

👋 @twstokes , looks like all feedback has been addressed in this PR and the WP app PRs also got a green light from reviewers so, wdyt about resuming the merge domino? First step in that direction would be to update this PR to point to Gutenberg's PR and the merged (or later) commit. Then we'll smoke test the main app PRs to avoid having something obvious regressed and merge the gb-mobile PR. We'll need to tag the merged gb-mobile state with an -alpha tag to update in the main apps. Let me know if you need me to elaborate on any of that, thanks!

Thanks @hypest! I believe all of that is clear to me - I appreciate the instructions!

@twstokes twstokes merged commit 95ec33f into develop Sep 30, 2021
@twstokes twstokes deleted the try/launch-support-from-inside-editor-2 branch September 30, 2021 19:25
@guarani guarani mentioned this pull request Oct 1, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants