-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contact Support from inside editor #3975
Conversation
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm "approving" this PR to make it clear and yeah, besides updating the Gutenberg hash we'll need to revert the submodule pointer after we get the Gutenberg PR merged.
4659ce0
to
961edcd
Compare
👋 @twstokes , looks like all feedback has been addressed in this PR and the WP app PRs also got a green light from reviewers so, wdyt about resuming the merge domino? First step in that direction would be to update this PR to point to Gutenberg's PR and the merged (or later) commit. Then we'll smoke test the main app PRs to avoid having something obvious regressed and merge the gb-mobile PR. We'll need to tag the merged gb-mobile state with an Edit: sorry, upon closer look, there's some pending (design) review on the Gutenberg PR so, let's hold of until @kyleaparker gets the chance to have another pass. |
Thanks @hypest! I believe all of that is clear to me - I appreciate the instructions! |
This PR enables developing the feature to contact support from inside the editor for WPiOS and WPAndroid.
To test: Follow instructions in the Gutenberg PR.
Related PRs
PR submission checklist: