Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embed block] Generic “No Preview” Embed preview UI #3927

Merged
merged 5 commits into from
Sep 11, 2021

Conversation

jd-alexander
Copy link
Contributor

Fixes #3277

To test:
Follow the instructions on WordPress/gutenberg#34626

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 7, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jd-alexander jd-alexander merged commit 8117950 into develop Sep 11, 2021
@jd-alexander jd-alexander deleted the issue-3277/embed-block-generic-no-preview branch September 11, 2021 23:27
@enejb enejb mentioned this pull request Sep 17, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Embed block] Implement generic “No Preview” Embed preview UI
2 participants