Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embed block] Fix content disappearing on Android when switching light/dark mode #3859

Merged
merged 12 commits into from
Sep 9, 2021
Merged

[Embed block] Fix content disappearing on Android when switching light/dark mode #3859

merged 12 commits into from
Sep 9, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Aug 20, 2021 •
edited
Loading

gutenberg PR: WordPress/gutenberg#34207

Fixes #3855 but it's not the optimal solution, it would be nice to investigate this further.

To test:
Follow testing instructions from gutenberg PR: WordPress/gutenberg#34207.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added [Type] Bug Something isn't working Embed block labels Aug 20, 2021
@fluiddot fluiddot self-assigned this Aug 20, 2021
@fluiddot fluiddot mentioned this pull request Aug 20, 2021
Merged
7 tasks
@fluiddot fluiddot marked this pull request as ready for review August 20, 2021 17:08
@fluiddot fluiddot requested a review from ceyhun August 20, 2021 17:08
@fluiddot fluiddot mentioned this pull request Aug 20, 2021
Closed
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 3, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

ceyhun
ceyhun approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#34207

@fluiddot fluiddot added this to the 1.62.0 (18.3) milestone Sep 9, 2021
@fluiddot
Copy link
Contributor Author

fluiddot commented Sep 9, 2021

I noticed that the Check Correctness CI check was failing due to changes in the package-lock.json file, I ran locally the command npm install and pushed the changes for that file in this commit.

@fluiddot fluiddot merged commit 3cdad33 into develop Sep 9, 2021
@fluiddot fluiddot deleted the embed-block-fix-android-dark-mode branch September 9, 2021 11:54
@enejb enejb mentioned this pull request Sep 17, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceyhun ceyhun ceyhun approved these changes

Assignees

@fluiddot fluiddot

Labels
Embed block [Type] Bug Something isn't working
Projects
None yet
Milestone
1.62.0 (18.3)
Development

Successfully merging this pull request may close these issues.

[Embed block] Fix issues related to content disappearing on Android
2 participants
@fluiddot @ceyhun