Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embed block] Add device's locale to preview content #3788

Merged
merged 6 commits into from
Sep 9, 2021
Merged

[Embed block] Add device's locale to preview content #3788

merged 6 commits into from
Sep 9, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Aug 3, 2021 •
edited
Loading

gutenberg PR: WordPress/gutenberg#33858

Fixes: #3773

To test:
Follow testing instructions from gutenberg PR: WordPress/gutenberg#33858.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot self-assigned this Aug 3, 2021
@fluiddot fluiddot mentioned this pull request Aug 3, 2021
Merged
7 tasks
@fluiddot fluiddot linked an issue Aug 3, 2021 that may be closed by this pull request
[Embed block] Add device's locale to preview content #3773
Closed
Base automatically changed from embed-block-preview to develop August 11, 2021 15:38
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 3, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot marked this pull request as ready for review September 3, 2021 17:14
jd-alexander
jd-alexander approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#33858 (review)

@fluiddot fluiddot added this to the 1.62.0 (18.3) milestone Sep 9, 2021
@fluiddot fluiddot enabled auto-merge September 9, 2021 16:37
@fluiddot fluiddot merged commit e9d46b1 into develop Sep 9, 2021
@fluiddot fluiddot deleted the embed-block-preview-locale branch September 9, 2021 16:53
@enejb enejb mentioned this pull request Sep 17, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd-alexander jd-alexander jd-alexander approved these changes

@ceyhun ceyhun Awaiting requested review from ceyhun

Assignees

@fluiddot fluiddot

Labels
Embed block [Type] Task
Projects
None yet
Milestone
1.62.0 (18.3)
Development

Successfully merging this pull request may close these issues.

[Embed block] Add device's locale to preview content
2 participants
@fluiddot @jd-alexander