Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Buildkite integration with publish to s3 plugin #3733

Merged
merged 38 commits into from
Jul 22, 2021

Conversation

oguzkocer
Copy link
Contributor

@oguzkocer oguzkocer commented Jul 17, 2021

This PR ports Android artifact publishing from CircleCI to Buildkite. It also integrates Android build file changes for react-native-bridge & react-native-aztec projects from WordPress/gutenberg#33441.

Note that WordPress/gutenberg#33441 needs to be merged and the gutenberg submodule needs to be updated before this PR can be merged.

To test:

  1. Test WPAndroid by updating ext.gutenbergMobileVersion in build.gradle to 3733-9e56603c19bf429f66b231806717f825bd90bf65
  2. Test the demo app and verify that it works as expected
  3. Test WPAndroid with composite build

I've been unable to run Test (2) and Test (3) as I am getting JS errors. I'd appreciate some help from a gutenberg-mobile developer. It turns out I just didn't initialize the block-experiments git submodule 🤦 Everything works fine now.

oguzkocer added 27 commits June 13, 2021 15:25
@oguzkocer oguzkocer force-pushed the add/buildkite-integration-with-publish-to-s3-plugin branch from 22d38cc to a47e2ea Compare July 17, 2021 08:16
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 17, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@oguzkocer oguzkocer requested a review from jkmassel July 20, 2021 19:29
Copy link
Contributor

@jkmassel jkmassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Test WPAndroid by updating ext.gutenbergMobileVersion in build.gradle to 3733-9e56603c19bf429f66b231806717f825bd90bf65
⚠️ Test the demo app and verify that it works as expected [I wasn't able to build this locally, but it's because of something on my machine]
✅ Test WPAndroid with composite build

@oguzkocer oguzkocer force-pushed the add/buildkite-integration-with-publish-to-s3-plugin branch from 4fa5ad7 to 39c0934 Compare July 21, 2021 21:13
@mchowning mchowning marked this pull request as ready for review July 22, 2021 19:55
@mchowning mchowning enabled auto-merge July 22, 2021 19:56
@mchowning mchowning disabled auto-merge July 22, 2021 20:57
@mchowning mchowning enabled auto-merge July 22, 2021 21:04
@mchowning mchowning merged commit 9e68be4 into develop Jul 22, 2021
@mchowning mchowning deleted the add/buildkite-integration-with-publish-to-s3-plugin branch July 22, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants