-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove yarn #3660
Remove yarn #3660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks Carlos! Only thing is that the iOS e2e test build seems to have failed in the JS bundling phase. I've tried bundling locally and it worked fine, not sure what's causing this issue on CI.
Thanks 🙇 ! Oh interesting, looks like it's not finding one of the dependencies from Jetpack 🤔 :
I'll try to re-run it to double-check that is safe to merge the PR. |
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
FWIW, the |
Thanks for sharing this ❤️ ! I'm wondering if it has to do with modifying the dependencies from the |
Looks like it worked on the second run: https://app.circleci.com/pipelines/github/wordpress-mobile/gutenberg-mobile/12778/workflows/be9d76f4-1043-4164-9e09-6b2275a24de3/jobs/69298 |
This PR removes the
yarn.lock
file and the yarn dependency as any of them are no longer.We used yarn for installing the dependencies from Jetpack but this has changed recently and now they're installed with pnpm.
Related PRs:
To test:
PR submission checklist: