Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove yarn #3660

Merged
merged 2 commits into from
Jun 24, 2021
Merged

Remove yarn #3660

merged 2 commits into from
Jun 24, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jun 24, 2021

This PR removes the yarn.lock file and the yarn dependency as any of them are no longer.

We used yarn for installing the dependencies from Jetpack but this has changed recently and now they're installed with pnpm.

Related PRs:

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot requested a review from ceyhun June 24, 2021 12:11
@fluiddot fluiddot self-assigned this Jun 24, 2021
Copy link
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Carlos! Only thing is that the iOS e2e test build seems to have failed in the JS bundling phase. I've tried bundling locally and it worked fine, not sure what's causing this issue on CI.

@fluiddot
Copy link
Contributor Author

LGTM! Thanks Carlos! Only thing is that the iOS e2e test build seems to have failed in the JS bundling phase. I've tried bundling locally and it worked fine, not sure what's causing this issue on CI.

Thanks 🙇 !

Oh interesting, looks like it's not finding one of the dependencies from Jetpack 🤔 :

ENOENT: no such file or directory, readlink '/Users/distiller/project/jetpack/node_modules/.pnpm/node_modules/@**********/color-studio'.

I'll try to re-run it to double-check that is safe to merge the PR.

@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@hypest
Copy link
Contributor

hypest commented Jun 24, 2021

FWIW, the color-studio package seems to be giving some trouble in local dev environments as well (internal Slack chat p1623793983431200-slack-C6UJ0KRKQ).

@fluiddot
Copy link
Contributor Author

fluiddot commented Jun 24, 2021

FWIW, the color-studio package seems to be giving some trouble in local dev environments as well (internal Slack chat p1623793983431200-slack-C6UJ0KRKQ).

Thanks for sharing this ❤️ ! I'm wondering if it has to do with modifying the dependencies from the package.json file because it's the only thing that this PR changed 🤔 .

@fluiddot
Copy link
Contributor Author

@fluiddot fluiddot merged commit 8b5e3aa into develop Jun 24, 2021
@fluiddot fluiddot deleted the update/remove-yarn branch June 24, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants