Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.55.0 #3609

Merged
merged 96 commits into from
Jun 11, 2021
Merged

Release 1.55.0 #3609

merged 96 commits into from
Jun 11, 2021

Conversation

antonis
Copy link

@antonis antonis commented Jun 11, 2021

Release for Gutenberg Mobile 1.55.0

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.
  • Test the Unsupported Block Editor on WP Apps (see steps).
  • Sanity test suites for WP Apps should be completed for each platform.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Approve and run optional Android and iOS UI tests
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release.
  • Bundle package of the release is updated.

Siobhan and others added 30 commits May 11, 2021 20:27
Updating gutenberg reference to include most recent commits.
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 11, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@@ -11,17 +11,14 @@
<string name="gutenberg_native_add_block_before" tools:ignore="UnusedResources">Add Block Before</string>
<string name="gutenberg_native_add_block_here" tools:ignore="UnusedResources">ADD BLOCK HERE</string>
<string name="gutenberg_native_add_button_text" tools:ignore="UnusedResources">Add button text</string>
<string name="gutenberg_native_add_caption" tools:ignore="UnusedResources">Add caption</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick way to verify that is safe to remove a localization key is by searching for this text in the code, if the text is referenced in a non-native file (basically a *.js) then it's ok to remove it as it will be included in the translations files.

Another way is to directly search for the text in the translation files (for example en-gb.json), if it exists then it's safe to remove it.

@antonis antonis requested a review from fluiddot June 11, 2021 13:36
@fluiddot
Copy link
Contributor

I've just reviewed the changes of the localization strings files and they're ok, in fact, now they match the version we have in develop (I diff compared both and there're no changes 🎊 ).

Thank you very much @antonis for wrangling the release 🙇 !

@antonis antonis requested a review from fluiddot June 11, 2021 13:45
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fluiddot fluiddot added this to the 1.55.0 (17.6) milestone Jun 11, 2021
@antonis antonis merged commit 5e2d062 into trunk Jun 11, 2021
@antonis antonis deleted the release/1.55.0 branch June 11, 2021 14:50
@geriux
Copy link
Contributor

geriux commented Jun 15, 2021

🟡 Sanity testing - Test Suite 4

Device: Redmi Note 8T
Build: 17.6-rc-1

DarkMode - 2

  • Spacer block - Dark mode - TC004
  • Buttons block - Dark mode - TC005
  • Group - Dark mode - TC006
  • Columns - Dark mode - TC007

Group - 2

  • Group - Navigation up button works as expected - TC009
  • Group - Navigation down works according to parent-first approach - TC010
  • Group - Cross navigation between blocks works as expected - TC011
  • Group - Ungroup button works as expected - TC012
  • Group - Check if in DarkMode all components gets proper colors - TC013
  • Group - Check if nested Placeholder block can be replaced - TC014

Spacer - 2

  • Spacer block - Settings: Available height range is correct - TC004
  • Spacer block - Settings: Height range extends if Spacer comes from the web is higher than 500px - TC005
  • Spacer block - Spacer in horizontal layout works as expected - TC006

Buttons - 4

  • Buttons block - Render custom text color - TC017
  • Buttons block - Render custom background color - TC016
  • Buttons block - Render gradient background color - TC018
  • Buttons block - Check if selection / caret color matches font color - TC020
  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview - TC021

Buttons - 5

  • Buttons block - Edit text styles - TC009
  • Buttons block - Render theme colors - TC019
  • ⚠️ Buttons block - Settings: Change Button border radius - TC015 - Visually the border gets changed but it is not being saved, looks like a breakage from this PR.

Buttons - 7

  • Buttons block - Link from the clipboard is automatically added into the empty URL field in link settings and button options - TC008
  • Buttons block - Toolbar link button is active when Button has link - TC022

Editor Theme - 2

  • Custom Gradients - Check that custom gradients load in the editor - TC004
  • Offline Support - TC005

Color Settings - 2

  • Pressing color swatch - TC004
  • Customize gradient color - TC005
  • Custom color picker - TC006

@antonis
Copy link
Author

antonis commented Jun 15, 2021

🟢 Writing Flow checklist (Android)

Device: Google Pixel 2 XL (Android 11)
Build: 17.6-rc-1

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@antonis
Copy link
Author

antonis commented Jun 15, 2021

🟢 Unsupported Block Tests (Android)

Device: Google Pixel 2 XL (Android 11)
Build: 17.6-rc-1

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@fluiddot
Copy link
Contributor

🟢 Writing Flow checklist (iOS)

Device: iPhone 11 (iOS 14.2)
Build: 17.6

General

  • TC001 - Block insertion flow
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
    • 🟡 Weird bottom-sheet transition when setting a value in "Link to" (see attached video capture)
Video capture
link-keyboard-visual-glitch.mp4
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@fluiddot
Copy link
Contributor

fluiddot commented Jun 15, 2021

🟡 Unsupported Block Tests (iOS)

Device: iPhone 11 (iOS 14.2)
Build: 17.6

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
    • 🟡 When editing a unsupported block, the message says that the block can be edited using the web version of the editor. Besides, tapping on the "Open Jetpack Security settings" button doesn't redirect to the settings.

  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@antonis
Copy link
Author

antonis commented Jun 15, 2021

🟢 Validated new features (Android)

Device: Google Pixel 2 XL (Android 11)
Build: 17.6-rc-1

✅ Image block: "Set as featured" button within image block settings. (Android only): #3116
✅ Audio block now available on WP.com sites on the free plan.: #3523

@fluiddot
Copy link
Contributor

🟢 Validated new features (iOS)

Device: iPhone 11 (iOS 14.2)
Build: 17.6

☑️ [This feature hasn't been tested as it's Android only] Image block: "Set as featured" button within image block settings. (Android only): #3116
✅ Audio block now available on WP.com sites on the free plan.: #3523

@enejb
Copy link
Contributor

enejb commented Jun 15, 2021

Result: 🔴 - button radius issue found.

Device: iPhone 11 Pro (iOS 14.2)
Build: 17.6 (Testflight 17.6.0000)

DarkMode - 2

  • Spacer block - Dark mode - TC004
  • Buttons block - Dark mode - TC005
  • Group - Dark mode - TC006
  • Columns - Dark mode - TC007

Group - 2

  • Group - Navigation up button works as expected - TC009
  • Group - Navigation down works according to parent-first approach - TC010
  • Group - Cross navigation between blocks works as expected - TC011
  • Group - Ungroup button works as expected - TC012
  • Group - Check if in DarkMode all components gets proper colors - TC013
  • Group - Check if nested Placeholder block can be replaced - TC014

Spacer - 2

  • Spacer block - Settings: Available height range is correct - TC004
  • 🟡 Spacer block - Settings: Height range extends if Spacer comes from the web is higher than 500px - TC005

The setting holds but if you move the slider the max setting returns to the default value of 500px. The change works the same as the web. so I am not sure if this is really an issue.

  • Spacer block - Spacer in horizontal layout works as expected - TC006

Buttons - 4

  • Buttons block - Render custom text color - TC017
  • Buttons block - Render custom background color - TC016
  • Buttons block - Render gradient background color - TC018
  • Buttons block - Check if selection / caret color matches font color - TC020
  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview - TC021

Buttons - 5

  • Buttons block - Edit text styles - TC009
  • Buttons block - Render theme colors - TC019
  • 🔴 Buttons block - Settings: Change Button border radius - TC015
    I also found that this doesn't work as expected on iOS. The radius property is never saved.

Buttons - 7

  • Buttons block - Link from the clipboard is automatically added into the empty URL field in link settings and button options - TC008
  • Buttons block - Toolbar link button is active when Button has link - TC022

Editor Theme - 2

  • Custom Gradients - Check that custom gradients load in the editor - TC004
  • Offline Support - TC005

Color Settings - 2

  • Pressing color swatch - TC004
  • Customize gradient color - TC005
  • Custom color picker - TC006

Minor Issue found.
The Cutom Gradiant Slider has the shadow cut off. See
Screen Shot 2021-06-15 at 12 25 26 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.