-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.55.0 #3609
Release 1.55.0 #3609
Conversation
Updating gutenberg reference to include most recent commits.
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
@@ -11,17 +11,14 @@ | |||
<string name="gutenberg_native_add_block_before" tools:ignore="UnusedResources">Add Block Before</string> | |||
<string name="gutenberg_native_add_block_here" tools:ignore="UnusedResources">ADD BLOCK HERE</string> | |||
<string name="gutenberg_native_add_button_text" tools:ignore="UnusedResources">Add button text</string> | |||
<string name="gutenberg_native_add_caption" tools:ignore="UnusedResources">Add caption</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick way to verify that is safe to remove a localization key is by searching for this text in the code, if the text is referenced in a non-native file (basically a *.js
) then it's ok to remove it as it will be included in the translations files.
Another way is to directly search for the text in the translation files (for example en-gb.json
), if it exists then it's safe to remove it.
I've just reviewed the changes of the localization strings files and they're ok, in fact, now they match the version we have in Thank you very much @antonis for wrangling the release 🙇 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊 !
Approved via wordpress-mobile/WordPress-iOS#16671 (review) and wordpress-mobile/WordPress-Android#14826 (review).
🟡 Sanity testing - Test Suite 4Device: Redmi Note 8T DarkMode - 2
Group - 2
Spacer - 2
Buttons - 4
Buttons - 5
Buttons - 7
Editor Theme - 2Color Settings - 2 |
🟢 Writing Flow checklist (Android)Device: Google Pixel 2 XL (Android 11) General
Rich Text Format
Splitting and merging
Undo / Redo - Test Cases
|
🟢 Unsupported Block Tests (Android)Device: Google Pixel 2 XL (Android 11)
|
🟢 Writing Flow checklist (iOS)Device: iPhone 11 (iOS 14.2) General
Rich Text Format
Video capturelink-keyboard-visual-glitch.mp4
Splitting and merging
Undo / Redo - Test Cases
|
🟡 Unsupported Block Tests (iOS)Device: iPhone 11 (iOS 14.2)
|
Result: 🔴 - button radius issue found. Device: iPhone 11 Pro (iOS 14.2) DarkMode - 2
Group - 2
Spacer - 2
The setting holds but if you move the slider the max setting returns to the default value of 500px. The change works the same as the web. so I am not sure if this is really an issue.
Buttons - 4
Buttons - 5
Buttons - 7
Editor Theme - 2Color Settings - 2Minor Issue found. |
Release for Gutenberg Mobile 1.55.0
Related PRs
Gutenberg: Mobile Release v1.55.0 WordPress/gutenberg#32619
WPAndroid: Integrate gutenberg-mobile release 1.55.0 WordPress-Android#14826
WPiOS: Integrate gutenberg-mobile release 1.55.0 WordPress-iOS#16671
Aztec-iOS: N/A
Aztec-Android: N/A
Extra PRs that Landed After the Release Was Cut
No extra PRs yet. 🎉
Changes
Test plan
Release Submission Checklist
RELEASE-NOTES.txt
is updated with all the changes that made it to the release.gutenberg/packages/react-native-editor/CHANGELOG.md
is updated with all the changes that made it to the release.