-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/gutenberg jetpack and package lock #3605
Conversation
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
👋 Matthew! Took the liberty to push the package-lock.json that my local |
The Correctness CI job fails with some eslint issues, most probably related to outdated way we invoke it. I left a comment on a relevant PR for help but, take a look too @mkevins if you can get to it, thanks! |
This aligns with the version used in the gutenberg submodule
Thanks Stefanos! Following up on the repllies in the thread of the relevant PR, I updated the version of I did not track down where / why we have our own dependency on the Also, for some reason when I ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mkevins and @hypest for handling this 🙇
I updated the version of eslint-pluging-jsdoc in gutenberg-mobile to align with the version used in gutenberg, and that seemingly resolved the issues we were seeing on CI.
The change LGTM and seems to work fine since the CI is green 🎉
I did not track down where / why we have our own dependency on the eslint-plugin-jsdoc, or whether it makes sense to remove it.
That's a good point. Maybe we should revisit this 🤔
Thanks for reviewing Antonis! |
Update Jetpack and Gutenberg reference, and update package lockfile.
To test:
Tests should pass on CI.
PR submission checklist: