Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: Fixes frozen editor scrolling in landscape on iPhone #3504

Merged
merged 1 commit into from
May 14, 2021

Conversation

antonis
Copy link

@antonis antonis commented May 14, 2021

Fixes: wordpress-mobile/WordPress-iOS#16476

gutenberg PR: WordPress/gutenberg#31795
WordPress-iOS PR: wordpress-mobile/WordPress-iOS#16497

To test:
See steps at WordPress/gutenberg#31795

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@antonis antonis added the [Type] Bug Something isn't working label May 14, 2021
@antonis antonis added this to the 1.53.0 (17.4) milestone May 14, 2021
@antonis antonis self-assigned this May 14, 2021
@antonis antonis requested a review from geriux May 14, 2021 08:39
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 14, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#31795 (review)

Lets remove the bundle changes before merging 👍

@antonis antonis force-pushed the fix/16476-iosLandscapeScrolling branch from 9d511d9 to 218a704 Compare May 14, 2021 13:31
@antonis antonis merged commit 1bcebcd into develop May 14, 2021
@antonis antonis deleted the fix/16476-iosLandscapeScrolling branch May 14, 2021 13:59
@AmandaRiu AmandaRiu mentioned this pull request May 14, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to scroll in the editor in landscape on iPhone
2 participants