Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add improvements to Reusable block #3391

Merged
merged 4 commits into from
Apr 29, 2021
Merged

Add improvements to Reusable block #3391

merged 4 commits into from
Apr 29, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Apr 19, 2021 •
edited
Loading

gutenberg PR: WordPress/gutenberg#30966

To test:
Check testing instructions in gutenberg PR.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot self-assigned this Apr 19, 2021
@fluiddot fluiddot mentioned this pull request Apr 19, 2021
Merged
7 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 19, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot marked this pull request as ready for review April 20, 2021 17:34
dcalhoun
dcalhoun approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#30966 (review).

I did notice that the latest gutenberg ref in this branch is not the latest in WordPress/gutenberg#30966. So, in my testing, I manually updated the gutenberg ref to be WordPress/gutenberg@26406a3 prior to testing.

We'll need to update the gutenberg ref to the merge commit once the sibling PR merges.

@fluiddot
Copy link
Contributor Author

Approved via WordPress/gutenberg#30966 (review).

I did notice that the latest gutenberg ref in this branch is not the latest in WordPress/gutenberg#30966. So, in my testing, I manually updated the gutenberg ref to be WordPress/gutenberg@26406a3 prior to testing.

We'll need to update the gutenberg ref to the merge commit once the sibling PR merges.

Thanks for the heads up regarding the gutenberg ref and sorry that it wasn't updated.

I've just updated the ref to the merge commit so the PR is ready to merge 🎊 .

@fluiddot fluiddot added this to the 1.52.0 (17.3) milestone Apr 29, 2021
@fluiddot fluiddot added the [Type] Enhancement Improves a current area of the editor label Apr 29, 2021
@fluiddot fluiddot merged commit 8c2c790 into develop Apr 29, 2021
@fluiddot fluiddot deleted the update/reusable-block-use-inner-block branch April 29, 2021 08:19
@cameronvoell cameronvoell mentioned this pull request Apr 30, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

@cameronvoell cameronvoell Awaiting requested review from cameronvoell

@guarani guarani Awaiting requested review from guarani

Assignees

@fluiddot fluiddot

Labels
Reusable block [Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
1.52.0 (17.3)
Development

Successfully merging this pull request may close these issues.
2 participants
@fluiddot @dcalhoun