Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.51.0 #3384

Merged
merged 76 commits into from
Apr 16, 2021
Merged

Release 1.51.0 #3384

merged 76 commits into from
Apr 16, 2021

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Apr 16, 2021

Release for Gutenberg Mobile 1.51.0

Related PRs

- Aztec-iOS: https://github.com/wordpress-mobile/AztecEditor-iOS/pull/
- Aztec-Android: https://github.com/wordpress-mobile/AztecEditor-Android/pull

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.

Release Submission Checklist

  • Approve and run optional Android and iOS UI tests
  • Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
  • Bundle package of the release is updated.

Siobhan and others added 30 commits March 9, 2021 11:21
This commit updates the Gutenberg reference to include the latest changes.
This commit updates the reference to Gutenberg to include the latest changes.
…alt-text-field

Image Block: Improve Text Entry for Long Alt Text
…o_develop

Merge release 1.50.0 to develop
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 16, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@dcalhoun dcalhoun marked this pull request as ready for review April 16, 2021 16:24
@dcalhoun dcalhoun requested a review from enejb April 16, 2021 16:24
Copy link
Contributor

@enejb enejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked well in my testing. 🥳

@dcalhoun dcalhoun merged commit addd3bf into trunk Apr 16, 2021
@dcalhoun dcalhoun deleted the release/1.51.0 branch April 16, 2021 18:55
@dcalhoun dcalhoun mentioned this pull request Apr 16, 2021
2 tasks
@mkevins
Copy link
Contributor

mkevins commented Apr 19, 2021

Test Suite 3 - iOS

Tested via iPhone 11 - iOS 14.4.2
Note: The ipa link had expired on the integration PR, so I restored the branch there to regenerate the installable build. The bot did not update the link, however, but I was able to find it via the CI logs.

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
    app doesn't re-ask for permission when selecting "choose from device" > Select photos > select nothing.
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC004
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Gallery - 4

  • Gallery block - Settings: Link to - TC012

Linkto - attachment page did not work for a self-hosted site. This is a known issue, so I'll add this to the test-case description.

  • Gallery block - Settings: Column number - TC013
  • Gallery block - Settings: Crop images - TC014

Columns - 2

  • Columns - Max limit of Column number - steps
  • Columns - Min limit of Column number - steps
  • Columns - Removing Column with remove button - steps
  • Columns - Removing the only one left Column with remove button - steps
  • Columns - Changing alignment on Columns - steps
  • Columns - Changing alignment on individual Columnn - steps
  • Columns - Alignment attribute is properly passed when adding Column - steps
  • Columns - Deep nesting is possible (iOS only)- steps

Columns - 3

  • Columns - Check if Column placeholders is visible for the unselected state - steps
  • Columns - Appearance in vertical device position (vertical layout) - steps
  • Columns - Appearance in horizontal device position (horizontal layout) - steps
  • Columns - Mover direction - steps
  • Columns - Check if Column placeholder is render in nested structure - steps
  • Columns - Unselected Column placeholder is streched to content in nested structure- steps

Columns - 4

  • ❌ Columns - Check if in DarkMode all components gets proper colors - steps

Only system darkmode is respected in the editor (app settings darkmode is ignored).

MediaText - 3

  • Media Text block - Insert video from device (failing) - TC001-v
  • Media Text block - Close/Re-open post with an ongoing video upload - TC003-v

MediaText - 4

  • Media Text block - Media & Text alignment - TC006
  • Media Text block - Vertical alignment - TC007

Shortcode-1

  • Shortcode block - Add a youtube link - steps

Cover - 2

  • Cover - Add Video Background from WordPress Media library - TC005 - loops flashing cursor write title to start writing
  • Cover - Replace media - TC006
  • Cover - Gradient background is rendered properly - TC007
  • Cover - Gradient overlay is rendered properly - TC008

Social Icons - 2

  • The link sheet is opened automatically when adding new icon - TC004
  • Ghost placeholder is visible when no icon is active - TC005
  • Social icon forwarding to the link - TC006

Image - 2

  • ❓ Image block - Switch to classic editor with an image block in page - TC006 - I couldn't find an option to switch to classic from within the editor. After leaving, changing the site settings to not use the block editor, and re-opening the post/page, it opens the existing content with the Gutenberg editor. This seems ok to me, but maybe this test is outdated, or perhaps needs to be removed?
  • Image block - Border style setting - TC007
  • Image block - Image size setting - TC008
  • Image block - Link to setting - TC009

Story block - 1

Note: The "confirm" button is an arrow, not a check mark. This might be expected, and if so, these tests may need to be updated to reflect that.

  • Story block - Verify is available in Block Picker - TC001
  • Story block - Verify is not available in Block Picker- TC002

For this test, the block was not available (as expected) for self-hosted sites. I could not find a way to test part A, though, with a version of jetpack previous to 9.1. I tried looking for an option w/ jurassic ninja, but couldn't find one. It would be helpful to add steps here on how to test with the precondition for previous jetpack versions. I was able to do this by uninstalling the Jetpack plugin and installing the 9.0.1 version from here. I will add these extra steps to the test-case.

  • Story block - Add media to empty Story block - TC003
  • Story block - Add media to non-empty Story block - TC004
  • Story block - Close/Re-open post with an ongoing Story upload - TC005

@antonis
Copy link

antonis commented Apr 19, 2021

Test Suite 4 - Android ✅

Device: Google Pixel 5, Android 11
APK: Build from integration PR

DarkMode - 2

  • Spacer block - Dark mode - TC004
  • Buttons block - Dark mode - TC005
  • Group - Dark mode - TC006
  • Columns - Dark mode - TC007

Group - 2

  • Group - Navigation up button works as expected - TC009
  • Group - Navigation down works according to parent-first approach - TC010
  • Group - Cross navigation between blocks works as expected - TC011
  • Group - Ungroup button works as expected - TC012
  • Group - Check if in DarkMode all components gets proper colors - TC013
  • Group - Check if nested Placeholder block can be replaced - TC014

Spacer - 2

  • Spacer block - Settings: Available height range is correct - TC004
  • Spacer block - Settings: Height range extends if Spacer comes from the web is higher than 500px - TC005
  • Spacer block - Spacer in horizontal layout works as expected - TC006

Buttons - 4

  • Buttons block - Render custom text color - TC017
  • Buttons block - Render custom background color - TC016
  • Buttons block - Render gradient background color - TC018
  • Buttons block - Check if selection / caret color matches font color - TC020
  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview - TC021

Buttons - 5

  • Buttons block - Edit text styles - TC009
  • Buttons block - Render theme colors - TC019
  • Buttons block - Settings: Change Button border radius - TC015

Buttons - 7

  • Buttons block - Link from the clipboard is automatically added into the empty URL field in link settings and button options - TC008
  • Buttons block - Toolbar link button is active when Button has link - TC022

Editor Theme - 2

  • Custom Gradients - Check that custom gradients load in the editor - TC004
  • Offline Support - TC005

Color Settings - 2

  • Pressing color swatch - TC004
  • Customize gradient color - TC005 => Existing issue
  • Custom color picker - TC006

@dcalhoun
Copy link
Member Author

dcalhoun commented Apr 19, 2021

🟡 iOS Writing Flow checklist (round 1)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

@enejb
Copy link
Contributor

enejb commented Apr 19, 2021

Writing Flow checklist - Round 1 Android

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@dcalhoun dcalhoun added this to the 1.51.0 (17.2) milestone Apr 20, 2021
@dcalhoun dcalhoun restored the release/1.51.0 branch April 26, 2021 18:02
@dcalhoun dcalhoun deleted the release/1.51.0 branch June 10, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.