Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix split/merge issue on native mobile by dropping selection update event when late #3239

Merged
merged 13 commits into from
Mar 18, 2021

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Mar 9, 2021

CI-testing PR to assess whether WordPress/gutenberg#29683 is a viable solution to its issue or not.

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

^ No release notes mention since we never shipped the regression to users. Actually, will add a [*] line so testers can be aware of the change and perhaps test out a few things.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 9, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jd-alexander jd-alexander changed the title Test out https://github.com/WordPress/gutenberg/pull/29683 Fix split/merge issue on native mobile by dropping selection update event when late Mar 17, 2021
@jd-alexander jd-alexander added this to the 1.50.0 (17.1) milestone Mar 17, 2021
@hypest hypest force-pushed the try/fix-split-issue-drop-selection-update-event branch from 0797230 to df4070f Compare March 18, 2021 10:57
@hypest hypest force-pushed the try/fix-split-issue-drop-selection-update-event branch from 5be54ef to 413554d Compare March 18, 2021 11:39
@hypest hypest merged commit 907271a into develop Mar 18, 2021
@hypest hypest deleted the try/fix-split-issue-drop-selection-update-event branch March 18, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants