-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix split/merge issue on native mobile by dropping selection update event when late #3239
Merged
hypest
merged 13 commits into
develop
from
try/fix-split-issue-drop-selection-update-event
Mar 18, 2021
Merged
Fix split/merge issue on native mobile by dropping selection update event when late #3239
hypest
merged 13 commits into
develop
from
try/fix-split-issue-drop-selection-update-event
Mar 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
2 tasks
jd-alexander
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved via WordPress/gutenberg#29683 (review)
jd-alexander
changed the title
Test out https://github.com/WordPress/gutenberg/pull/29683
Fix split/merge issue on native mobile by dropping selection update event when late
Mar 17, 2021
hypest
force-pushed
the
try/fix-split-issue-drop-selection-update-event
branch
from
March 18, 2021 10:57
0797230
to
df4070f
Compare
hypest
force-pushed
the
try/fix-split-issue-drop-selection-update-event
branch
from
March 18, 2021 11:39
5be54ef
to
413554d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI-testing PR to assess whether WordPress/gutenberg#29683 is a viable solution to its issue or not.
To test:
PR submission checklist:
^
No release notes mention since we never shipped the regression to users.Actually, will add a[*]
line so testers can be aware of the change and perhaps test out a few things.