Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.46.2 #3175

Merged
merged 7 commits into from
Feb 18, 2021
Merged

Release 1.46.2 #3175

merged 7 commits into from
Feb 18, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Feb 18, 2021

Release for Gutenberg Mobile 1.46.2

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.

For testing the specific changes of the beta fix follow the following steps:

  1. Add the following code to a post.
<!-- wp:jetpack/story {"mediaFiles":[{"alt":"","caption":"","id":320,"link":"https://cldup.com/n48GTQmw7s.jpg","mime":"image/jpeg","type":"image","url":"https://cldup.com/n48GTQmw7s.jpg"},{"alt":"","caption":"","id":321,"link":"https://cldup.com/u2kdydrlQv.jpg","mime":"image/jpeg","type":"image","url":"https://cldup.com/u2kdydrlQv.jpg"},{"alt":"","caption":"","id":319,"link":"https://cldup.com/fi7gqyUrbL.jpg","mime":"image/jpeg","type":"image","url":"https://cldup.com/fi7gqyUrbL.jpg"}]} -->
<div class="wp-block-jetpack-story wp-story"></div>
<!-- /wp:jetpack/story -->

<!-- wp:jetpack/story -->
<div class="wp-block-jetpack-story wp-story"></div>
<!-- /wp:jetpack/story -->

<!-- wp:jetpack/story {"mediaFiles":[]}} -->
<div class="wp-block-jetpack-story wp-story"></div>
<!-- /wp:jetpack/story -->
  1. Open the post on the iOS version of the WordPress app.
  2. Tap on the different Story blocks.
  3. Observer that no crash is produced.

Release Submission Checklist

  • Approve and run optional Android and iOS UI tests
  • Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
  • Bundle package of the release is updated.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 18, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot requested a review from ceyhun February 18, 2021 13:40
@ceyhun ceyhun marked this pull request as ready for review February 18, 2021 14:31
Copy link
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with WPiOS 42470 build with iPhone 11 Pro, iOS 14.4
As a smoke test I tested typing in a paragraph, formatting, splitting and merging, adding an image block and uploading from device, switching dark mode on and off.
I tested both on a free .com site and a self-hosted Jetpack connected site.
Seems to work fine 🎉

@fluiddot
Copy link
Contributor Author

I also run a quick smoke test:

  • TC001 - Paste formatted text copied from website
  • Typing in paragraph and heading block
  • Block insertion - Test Cases
  • Splitting/merge paragraph block
  • Undo/redo text
  • Entering exiting the editor
  • Rotate the device in various cases
  • Open and dismiss the bottom sheet
  • Background the app and foreground it again
  • Make some changes in a post, close the app, open it again and verify that the changes are saved

Additionally I double check that the Story block crash it not reproducible.

Tested on iPhone 11 - iOS 14.2, WPiOS 16.7 - build 42470.

@fluiddot fluiddot merged commit dc6d1a9 into trunk Feb 18, 2021
@fluiddot fluiddot deleted the release/1.46.2 branch February 18, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants