Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add capability to bridge to show/hide audio block #3129

Merged
merged 3 commits into from
Feb 15, 2021
Merged

Add capability to bridge to show/hide audio block #3129

merged 3 commits into from
Feb 15, 2021

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Feb 11, 2021 •
edited
Loading

Adds capability to bridge to show/hide audio block

gutenberg PR: WordPress/gutenberg#28952
WPAndroid PR: wordpress-mobile/WordPress-Android#14037
WPiOS PR: wordpress-mobile/WordPress-iOS#15865

To test:

  1. Switch to a free/simple site
  2. Open editor
  3. Tap block inserter
  4. Audio Block should not be in the list

  1. Switch to a paid/self-hosted site
  2. Open editor
  3. Tap block inserter
  4. Audio Block should be in the list

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@ceyhun ceyhun added the [Status] DO NOT MERGE Do not merge this PR label Feb 11, 2021
@ceyhun ceyhun requested a review from jd-alexander February 11, 2021 15:54
This was referenced Feb 11, 2021
Merged
Merged
Merged
@ceyhun ceyhun force-pushed the feat/show-hide-audio-block branch from 2c601a8 to 7030a69 Compare February 15, 2021 14:26
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 15, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@ceyhun ceyhun changed the base branch from release/1.46.0 to release/1.46.1 February 15, 2021 14:26
@ceyhun ceyhun removed the [Status] DO NOT MERGE Do not merge this PR label Feb 15, 2021
@ceyhun ceyhun added this to the 1.46.1 (16.7) milestone Feb 15, 2021
jd-alexander
jd-alexander approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#28952 (review)

@jd-alexander jd-alexander merged commit 23569f3 into release/1.46.1 Feb 15, 2021
@jd-alexander jd-alexander deleted the feat/show-hide-audio-block branch February 15, 2021 19:52
@fluiddot fluiddot mentioned this pull request Feb 17, 2021
Merged
3 tasks
@dcalhoun dcalhoun mentioned this pull request Feb 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd-alexander jd-alexander jd-alexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.46.1 (16.7)
Development

Successfully merging this pull request may close these issues.
2 participants
@ceyhun @jd-alexander