Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix download button in File block #3102

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Fix download button in File block #3102

merged 1 commit into from
Feb 4, 2021

Conversation

lukewalczak
Copy link
Contributor

Fixes #WordPress/gutenberg#28706

gb PR: WordPress/gutenberg#28704

To test:

Add file block
Add file from device
Observe the button
Expect button opacity is lowered

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@lukewalczak lukewalczak added this to the 1.46 (16.7) milestone Feb 4, 2021
@lukewalczak lukewalczak self-assigned this Feb 4, 2021
fluiddot
fluiddot approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved via WordPress/gutenberg#28704 (review)

@fluiddot fluiddot mentioned this pull request Feb 4, 2021
Merged
3 tasks
@lukewalczak lukewalczak merged commit a8184d3 into develop Feb 4, 2021
@lukewalczak lukewalczak deleted the fix-disabled-button-file branch February 4, 2021 10:46
@dcalhoun dcalhoun mentioned this pull request Feb 16, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluiddot fluiddot fluiddot approved these changes

Assignees

@lukewalczak lukewalczak

Labels
bugfix
Projects
None yet
Milestone
1.46 (16.7)
Development

Successfully merging this pull request may close these issues.
2 participants
@lukewalczak @fluiddot