Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move custom indicator to be rendered above the colors #3098

Merged
merged 2 commits into from
Feb 4, 2021

Conversation

lukewalczak
Copy link
Contributor

Fixes: #3097

To test:

  1. Go to a post/page.
  2. Add Buttons block.
  3. Tap on the gear button.
  4. Tap on Background Color options.
  5. Switch several times between Solid and Gradient segments.
    Expect app mustn't crash

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@lukewalczak lukewalczak changed the title Update ref: Move custom indicator to be rendered above the colors to … Move custom indicator to be rendered above the colors Feb 3, 2021
@fluiddot fluiddot self-requested a review February 3, 2021 17:03
@fluiddot fluiddot added the [Type] Bug Something isn't working label Feb 3, 2021
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved via WordPress/gutenberg#28698 (review).

@fluiddot fluiddot mentioned this pull request Feb 3, 2021
3 tasks
@fluiddot
Copy link
Contributor

fluiddot commented Feb 4, 2021

@lukewalczak I think this PR is ready to be merged, although first we should resolve the conflict in the gutenberg submodule reference.

@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@lukewalczak lukewalczak merged commit a48e252 into develop Feb 4, 2021
@lukewalczak lukewalczak deleted the fix-seg-controls-crash branch February 4, 2021 12:49
@fluiddot fluiddot added this to the 1.46 (16.7) milestone Feb 4, 2021
@dcalhoun dcalhoun mentioned this pull request Feb 16, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colors segmented controls crash when switching quick
2 participants