Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show "Add to beginning" and "Add to end" option for all blocks when long-pressing the inserter button #3074

Merged
merged 5 commits into from
Feb 9, 2021
Merged

Show "Add to beginning" and "Add to end" option for all blocks when long-pressing the inserter button #3074

merged 5 commits into from
Feb 9, 2021

Conversation

AmandaRiu
Copy link
Contributor

@AmandaRiu AmandaRiu commented Jan 29, 2021 •
edited
Loading

Fixes #2344

Related PR

gutenberg: WordPress/gutenberg#28610

To test:

  1. Open the demo app
  2. Long-press on the inserter button, verify options Add to beginning and Add to end are displayed.
  3. Tap on Add to beginning and select a block. Verify block added to the beginning.
  4. With no block selected, long-press on inserter again, this time tap on Add to end and select a block. Verify added to end of post.
  5. Select a block in the editor, then long-press on the inserter. Verify new options Add to beginning and Add to end are displayed.
  6. Tap on Add to beginning and select a block. Verify added to beginning of document.
  7. Repeat for the other options available when long-pressing on inserter with a block selected and verify each work.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 29, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@AmandaRiu AmandaRiu mentioned this pull request Jan 29, 2021
Merged
6 tasks
@cameronvoell cameronvoell added this to the 1.47 (16.8) milestone Feb 5, 2021
cameronvoell
cameronvoell approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#28610 (review)

After we update the gutenberg reference on this PR, it should be ready to merge. Nice work 👍

cameronvoell
cameronvoell approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cameronvoell cameronvoell merged commit 1b5f8f7 into develop Feb 9, 2021
@cameronvoell cameronvoell deleted the rnmobile/2344-long-press-optioons branch February 9, 2021 18:25
fluiddot
fluiddot reviewed Feb 12, 2021
View reviewed changes
RELEASE-NOTES.txt
@@ -7,6 +7,7 @@ Unreleased
* [**] Add support for setting heading anchors [#2947]
* [**] Disable Unsupported Block Editor for Reusable blocks [#3067]
* [**] Add proper handling for single use blocks such as the more block [#3042]
* [**] Make inserter long-press options "add to beginning" and "add to end" always available. [#3074]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 I realised that this change is assigned to 1.47 milestone but here in the release notes is under the 1.46.0 section, it would be nice to have it under the Unreleased section instead of here since it wasn't released on that version.

cc @AmandaRiu

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fluiddot I'll open another PR to make that change 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I've just approved and merge it 🎊 .

@AmandaRiu AmandaRiu mentioned this pull request Feb 12, 2021
Merged
2 tasks
@fluiddot
Copy link
Contributor

👋 I'm moving this to 1.46.1 milestone because it's going to be included in the beta fix.

Long story short, a PR was merged into the WordPress Android app after the 1.46.0 release was cut and due to the gutenberg-mobile submodule update these changes were included too.

Let me know if there's any concern about including in the beta fix, thanks!

@fluiddot fluiddot modified the milestones: 1.47 (16.8), 1.46.1 (16.7) Feb 15, 2021
@fluiddot fluiddot mentioned this pull request Feb 15, 2021
Merged
3 tasks
@dcalhoun dcalhoun mentioned this pull request Feb 16, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluiddot fluiddot fluiddot left review comments

@cameronvoell cameronvoell cameronvoell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.46.1 (16.7)
Development

Successfully merging this pull request may close these issues.

Show "Add to beginning" and "Add to end" option for all blocks when long-pressing the inserter button
3 participants
@AmandaRiu @fluiddot @cameronvoell