-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contact Info - Adding Feature Flag + Jetpack API Version Check #3001
Conversation
This is a bug on iOS, as I verified it doesn't happen like this on WPAndroid. Can you file it (and perhaps fix it) on iOS please @illusaen ? What I understand should happen is that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here look good to me @illusaen ! 🎉
One thing I noticed, the gutenberg git submodule commit hash wasn't updated in this PR. We should merge develop
back into your branch so to update it and then also update and add the gutenberg
submodule commit hash as well. I've done it in a follow up PR of mine which is targeting this PR of yours so, please hold back from merging this one until mine is merged on top of yours first 👍 (we can chat about it too to coordinate)
Nice job!
BTW regarding this @illusaen :
To check which version of Jetpack shipped with ContactInfo block originally, you can see the commit history in Jetpack TODO: it would be safer to also check whether the Contact Info block on the web side of things is available from that point on (I think it would probably be the case but, just to double check). |
@illusaen I'm not sure on the technical side, but in terms of behavior from the user's perspective, I would expect the list of blocks to reset to whatever the currently-selected site supports, per @mzorz's comment above.
I'm not sure on this, but it looks like Mario might've given you an answer above 😄 Before we move forward, I'd like to do a final design review — would you mind creating test builds for iOS and Android so I can give it a spin? |
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
Took your Android PR, which is set to 8.5, thanks much!! |
fbdd9d7
to
4ea5a4b
Compare
230e9ed
to
025bc40
Compare
610fd24
to
eb86c71
Compare
Closing in favor of #3090 because there were some weird bundle changes that happened in this branch due to merge issues. |
Reopening! this happened look at the changes in this PR https://github.com/wordpress-mobile/gutenberg-mobile/pull/3037/files
|
eb86c71
to
fcf8cf5
Compare
…ions; splitting out dev flag removal for later PR.
Changing this PR to only add in the feature flag + Jetpack API version checks; removing the dev flag change to a later PR so that I can first fix the additional bug that @iamthomasbishop found where selecting and then deselecting the Address block results in an unhideable keyboard. |
e69a8ab
to
019a7e3
Compare
019a7e3
to
946a941
Compare
Fixes #2166
Added native bridge capabilities for iOS and Android in order to determine whether contact info should be shown or not.
Notes (@iamthomasbishop):
Links:
gutenberg
: #28168WPiOS
: #15634WPAndroid
: #13758WPAndroid
: #13804Tests:
Self-hosted
WPcom site
Screenshots:
PR submission checklist: