Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable blocks - Present block content (preview mode) #2953

Merged
merged 4 commits into from
Jan 21, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jan 4, 2021

Gutenberg PR -> WordPress/gutenberg#25265

Second part (adding Reusable blocks to the inserter menu):
Gutenberg PR -> WordPress/gutenberg#25383
Gutenberg-mobile PR -> #2644

Related to #2575

This PR is the first part of the issue Add Support to Insert Existing Reusable Blocks from the Editor.

The scope of this issue is limited to add Reusable blocks to the inserter menu, however due to the need of registering the Reusable block type (core/block), I also had to add support for presenting it in the editor.

The edition support will be added in this issue, so for now this PR only provides the preview mode of this type of block.

To test:
Check test steps in Gutenberg PR WordPress/gutenberg#25265

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 4, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot
Copy link
Contributor Author

fluiddot commented Jan 4, 2021

Check correctness is also failing in the Dependabot's PR for bumping Gutengerg.

@fluiddot fluiddot requested review from guarani and dcalhoun January 7, 2021 08:42
@fluiddot fluiddot force-pushed the 2575-support-reusable-blocks branch 3 times, most recently from a95092a to 8f44856 Compare January 8, 2021 17:48
@guarani guarani removed their request for review January 9, 2021 00:57
@guarani
Copy link
Contributor

guarani commented Jan 9, 2021

Just removing myself as reviewer since I won't be around for the next two weeks.

@fluiddot fluiddot force-pushed the 2575-support-reusable-blocks branch from 8f44856 to 4a002f2 Compare January 13, 2021 08:34
@fluiddot fluiddot mentioned this pull request Jan 14, 2021
42 tasks
@fluiddot fluiddot requested review from ceyhun and removed request for dcalhoun January 15, 2021 11:00
Copy link
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed via: WordPress/gutenberg#25265. We can merge this after the gutenberg PR is merged and the ref is updated.

@fluiddot fluiddot force-pushed the 2575-support-reusable-blocks branch from 848fba1 to 5b392cd Compare January 19, 2021 12:54
@fluiddot fluiddot changed the title Add support Reusable blocks Reusable blocks - Present block content (preview mode) Jan 19, 2021
@fluiddot
Copy link
Contributor Author

Gutenberg submodule updated, now it's pointing to the merge commit of the Gutenberg PR in master.

@fluiddot fluiddot added this to the 1.46 (16.7) milestone Jan 21, 2021
@fluiddot fluiddot merged commit ab7e9a6 into develop Jan 21, 2021
@fluiddot fluiddot deleted the 2575-support-reusable-blocks branch January 21, 2021 11:01
@fluiddot fluiddot mentioned this pull request Feb 1, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocks [Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants