Adding block moving to top and to bottom functionality.

[illusaen]

Fixes #1191
Gutenberg link: PR 27554

To Test:

Case 1

1. Insert paragraph block. Type text.
2. Insert second paragraph block. Type text.
3. Insert header block.
4. Long press up button on header block.
5. Press "Move to top" on action sheet that pops up.
6. Verify that header block is on top.

Case 2

1. Insert paragraph block. Type text.
2. Insert second paragraph block. Type text.
3. Insert header block.
4. Select first paragraph block.
5. Long press down button on paragraph block.
6. Press "Move to bottom" on action sheet that pops up.
7. Verify that the first paragraph block is on bottom.

Case 3

1. Insert paragraph block. Type text.
2. Insert second paragraph block. Type text.
3. Insert header block.
4. Long press up button on header block.
5. Press "Cancel" on action sheet that pops up.
6. Verify that no changes have been made in block order.

Case 1

1. Insert paragraph block. Type text.
2. Insert second paragraph block. Type text.
3. Insert header block.
4. Select first paragraph block.
5. Long press down button on paragraph block.
6. Press "Cancel" on action sheet that pops up.
7. Verify that no changes have been made in block order.

PR submission checklist:

• I have considered adding unit tests where possible.
• I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

[hypest]

👋 @illusaen , thanks for the PR!

A couple of suggestions if I may:

1. What do you think about using the "Fixes #" format in the beginning of the PR description, so the ticket gets automatically closed when this PR merges? See this relevant GitHub documentation.
2. Let's add a "To test:" section, to have exact steps to follow to test the functionality. I see there's a "How it was tested" section in the Gutenberg PR, which you can reshape into a list of steps for the tester/reviewer to follow. For example, something like the "Testing" section in this PR. Thanks!

[illusaen]

👋 @illusaen , thanks for the PR!

A couple of suggestions if I may:

1. What do you think about using the "Fixes #" format in the beginning of the PR description, so the ticket gets automatically closed when this PR merges? See this [relevant GitHub documentation](https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword).

Yes that makes sense!

2. Let's add a "To test:" section, to have exact steps to follow to test the functionality. I see there's a "How it was tested" section in the Gutenberg PR, which you can reshape into a list of steps for the tester/reviewer to follow. For example, something like the "Testing" section [in this PR](https://github.com/WordPress/gutenberg/pull/25031). Thanks!

Quick question on that -- I added that section for the gutenberg PR -- should I copy/paste it here?

[cameronvoell]

Hi @illusaen , when I updated the CI on this PR to run the full suite of Android and iOS e2e tests, it looks like the new Block Mover Tests are failing on Android, and we are seeing some failures on iOS as well. I was able to confirm the Android e2e test failures locally.

Can you confirm whether you were able to see the e2e tests all passing locally for both Android and iOS?

[hypest]

Quick question on that -- I added that section for the gutenberg PR -- should I copy/paste it here?

I noticed the list there, but I'd recommend an expanded one (say, a bulleted list for each test case) with simple steps on each line to follow easily. I understand the current format is an abbreviated one with one test per bullet, right?

By the way, a nit: Looks like there's a space character inside the [ x] marks in the PR description, and GitHub markdown fails to recognize that as a checked checkmark. Not sure if you intentionally have that like that?

[illusaen]

I noticed the list there, but I'd recommend an expanded one (say, a bulleted list for each test case) with simple steps on each line to follow easily. I understand the current format is an abbreviated one with one test per bullet, right?

Makes sense, changed!

By the way, a nit: Looks like there's a space character inside the [ x] marks in the PR description, and GitHub markdown fails to recognize that as a checked checkmark. Not sure if you intentionally have that like that?

So I didn't actually realize that that was a specific markdown thing; fixed!

[cameronvoell]

Changes look good. Full tests passed here . Nice work @illusaen !