Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio Block - I #2854

Merged
merged 1 commit into from
Jan 28, 2021
Merged

Audio Block - I #2854

merged 1 commit into from
Jan 28, 2021

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Dec 1, 2020 •
edited by cameronvoell
Loading

This PR updates the gutenberg ref to test WordPress/gutenberg#27401
WPiOS side PR: wordpress-mobile/WordPress-iOS#15420
WPAndroid PR: wordpress-mobile/WordPress-Android#13808

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@etoledom etoledom added the Blocks label Dec 1, 2020
@etoledom etoledom added this to the 1.43 (16.4) milestone Dec 1, 2020
@etoledom etoledom requested a review from jd-alexander December 1, 2020 15:11
@etoledom etoledom self-assigned this Dec 1, 2020
This was referenced Dec 1, 2020
Merged
Merged
@jd-alexander
Copy link
Contributor

Bumping the milestone to 1.44, feel free to ping me if it needs to make it to 1.43 this week.

@jd-alexander jd-alexander modified the milestones: 1.43 (16.4), 1.44 (16.5) Dec 7, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 16, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@jd-alexander jd-alexander mentioned this pull request Dec 17, 2020
Merged
3 tasks
@guarani
Copy link
Contributor

guarani commented Jan 4, 2021

Hi @jd-alexander, we're cutting the release now so I'll bump this to 1.45.0. Please let me know if you think it needs to be included in this release and we can arrange that.

@guarani guarani modified the milestones: 1.44 (16.5), 1.45 (16.6) Jan 4, 2021
@cameronvoell
Copy link
Contributor

Hi @jd-alexander, we're cutting the release now so I'll bump this to 1.45.0. Please let me know if you think it needs to be included in this release and we can arrange that.

Bumping to 1.46.0, let me know if there are any issues with that.

@cameronvoell cameronvoell modified the milestones: 1.45 (16.6), 1.46, 1.46 (16.7) Jan 18, 2021
@jd-alexander jd-alexander mentioned this pull request Jan 18, 2021
Merged
3 tasks
jd-alexander
jd-alexander approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#27401 (review)

@jd-alexander jd-alexander merged commit 35d0931 into develop Jan 28, 2021
@jd-alexander jd-alexander deleted the audio-block-I branch January 28, 2021 22:16
@fluiddot fluiddot mentioned this pull request Feb 1, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd-alexander jd-alexander jd-alexander approved these changes

Assignees

@etoledom etoledom

Labels
Blocks
Projects
None yet
Milestone
1.46 (16.7)
Development

Successfully merging this pull request may close these issues.
4 participants
@etoledom @jd-alexander @guarani @cameronvoell