Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use link picker in Image block #2841

Merged
merged 14 commits into from
Dec 21, 2020
Merged

Use link picker in Image block #2841

merged 14 commits into from
Dec 21, 2020

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Nov 26, 2020 •
edited
Loading

Related PRs

gutenberg: WordPress/gutenberg#27292
WordPress-Android: wordpress-mobile/WordPress-Android#13576

Description

This PR adds the link picker functionality to the Image block settings.

To test:
Testing steps here: WordPress/gutenberg#27292 (comment)

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@mkevins mkevins added the [Type] Enhancement Improves a current area of the editor label Nov 26, 2020
@mkevins mkevins mentioned this pull request Nov 26, 2020
Merged
6 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 10, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@mkevins mkevins mentioned this pull request Dec 10, 2020
Closed
3 tasks
@mkevins mkevins requested a review from enejb December 16, 2020 11:27
@mkevins mkevins marked this pull request as ready for review December 16, 2020 11:28
@enejb
Copy link
Contributor

enejb commented Dec 17, 2020

Lets rebase this and add some release notes :)

enejb
enejb approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@enejb enejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Ship it!

@mkevins mkevins merged commit 3586bbf into develop Dec 21, 2020
@mkevins mkevins deleted the try/image-block-link-picker branch December 21, 2020 00:57
@mkevins
Copy link
Contributor Author

mkevins commented Dec 21, 2020

Thank you for testing and reviewing Enej!

@hypest hypest mentioned this pull request Dec 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enejb enejb enejb approved these changes

Assignees
No one assigned
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkevins @enejb