Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stories: moved __DEV__ flag to contact-info block availability declaration only #2795

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Nov 11, 2020

This PR moved the __DEV__ flag up to a per-block granularity. Registering the jetpack editor code is no longer behind the dev flag, and now blocks that are in development can be added to the supportedJetpackBlocks dictionary with availability set to true|false or a flag (as is the case for the Contact Info block).

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@mzorz mzorz added Jetpack Bug or feature related to Jetpack Story block labels Nov 11, 2020
@mzorz mzorz requested review from aforcier and etoledom November 11, 2020 02:48
@mzorz mzorz requested review from jd-alexander and removed request for aforcier November 11, 2020 03:13
@mzorz mzorz changed the title Stories: moved __DEV__ flag to contact-info block availability decl only Stories: moved __DEV__ flag to contact-info block availability declaration only Nov 11, 2020
@aforcier
Copy link

Confirmed that with wordpress-mobile/WordPress-Android#13355 Story blocks are rendered in the editor and I can edit them.

Also confirmed that a contact info block only shows up as supported if wp.BUILD_GUTENBERG_FROM_SOURCE = true.

I'll let @jd-alexander or someone else also double check things but this looks good to me! :shipit:

@etoledom etoledom added this to the 1.42 milestone Nov 11, 2020
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iOS and the new block doesn't show as expected.
Code looks great and I trust @aforcier with Android side 🎉

@mzorz
Copy link
Contributor Author

mzorz commented Nov 12, 2020

Thank you both @etoledom @aforcier ! 🙇

@mzorz mzorz merged commit 8294ef6 into develop Nov 12, 2020
@mzorz mzorz deleted the try/lift-dev-flag-on-stories-block branch November 12, 2020 01:11
@cameronvoell cameronvoell mentioned this pull request Nov 23, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Bug or feature related to Jetpack Story block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants