Add support for Story block rendering (part 3): rename refactor #2706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
This was referenced Oct 10, 2020
This was referenced Oct 11, 2020
etoledom
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
Approved via Automattic/jetpack#17456 (review) and WordPress/gutenberg#26005 (review)
Since this CI error also happens on the target branch, let's merge and solve the issue on the target branch itself 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains needed work to rename component to
BlockMediaUpdateProgress(see Automattic/jetpack#17456)Related PRs:
Gutenberg: WordPress/gutenberg#26005
Jetpack: Automattic/jetpack#17456
WPAndroid: wordpress-mobile/WordPress-Android#13101
To test:
These changes aim at having a more generalized naming of methods that allow them to signify they are indeed reusable.
Given the Story block intrinsically is a collection of files represented by an object array named
mediaFiles,we're giving collectively these names to the related method, for exampleonStoryCreatorRequestListenerhas been renamed toonMediaFilesEditorLoadRequestListener, given from Gutenberg the mediaFiles array gets passed on so it can be modified externally and then be replaced back once done editing.PR submission checklist: