-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify media insertion flow #2700
Simplify media insertion flow #2700
Conversation
Removed submodule gutenberg
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding my approval here, since I already reviewed and approved WordPress/gutenberg#25031 (review).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just approving this since the linked Gutenberg PRs are approved. I think this is missing an entry in the release notes though (and we're missing an entry in the react-native-editor
package change log).
Thanks. I was planning to put the release notes in and request a review from you. Can I just put them in and merge afterwards ? |
Yeah sure, I don't mind either way. |
No problem. I will sync with trunk and get all these PRs merged in on Monday. |
Fixes #946
Gutenberg PR WordPress/gutenberg#29546
This change simplifies the media insertion flow by showing the media options sheet when you tap the Media block to add the Media placeholder to the canvas. Before you would have to add the placeholder and click for eg. Add Image for it to be shown.
To test:
WordPress/gutenberg#29546
PR submission checklist: