Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update masked-view version #2686

Merged
merged 6 commits into from
Oct 6, 2020
Merged

Update masked-view version #2686

merged 6 commits into from
Oct 6, 2020

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Oct 2, 2020

gutenberg side PR: WordPress/gutenberg#25794
WPiOS side PR: wordpress-mobile/WordPress-iOS#15035

This PR updates the react-native-masked-view version to v1.0.10-wp.
This version was created in our fork to solve an issue with Cocoapods on WPiOS.

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@etoledom etoledom self-assigned this Oct 2, 2020
@etoledom etoledom marked this pull request as ready for review October 2, 2020 15:27
@etoledom etoledom requested a review from ceyhun October 2, 2020 15:28
@etoledom etoledom added this to the 1.39 milestone Oct 2, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 2, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etoledom etoledom merged commit 5ff9336 into develop Oct 6, 2020
@etoledom etoledom deleted the update-masked-view branch October 6, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants