Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gradle-node-plugin to use actively maintained fork #2607

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Update gradle-node-plugin to use actively maintained fork #2607

merged 1 commit into from
Sep 11, 2020

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Sep 10, 2020 •
edited
Loading

See WordPress/gutenberg#25208 for description and testing steps.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@mchowning mchowning self-assigned this Sep 10, 2020
@mchowning mchowning added this to the 1.37 milestone Sep 10, 2020
@mchowning mchowning mentioned this pull request Sep 10, 2020
Merged
6 tasks
marecar3
marecar3 approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's working as expected!

@mchowning mchowning force-pushed the update_gradle-node-plugin branch from 7512f99 to f627c98 Compare September 11, 2020 13:21
@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@mchowning mchowning merged commit 2873c72 into develop Sep 11, 2020
@mchowning mchowning deleted the update_gradle-node-plugin branch September 11, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marecar3 marecar3 marecar3 approved these changes

@cameronvoell cameronvoell Awaiting requested review from cameronvoell

Assignees

@mchowning mchowning

Labels
None yet
Projects
None yet
Milestone
1.37
Development

Successfully merging this pull request may close these issues.
2 participants
@mchowning @marecar3