Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Fix empty rich-text with no height on RTL layout #2544

Merged
merged 2 commits into from
Aug 14, 2020
Merged

[iOS] Fix empty rich-text with no height on RTL layout #2544

merged 2 commits into from
Aug 14, 2020

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Aug 12, 2020 •
edited
Loading

Fixes #

PR to test WordPress/gutenberg#24510
WPiOS PR: wordpress-mobile/WordPress-iOS#14630

RTL

To test:

  • Run the project from Fix Gutenberg empty fields with on RTL layout WordPress-iOS#14630.
  • Set the Application Language to a RTL language (Hebrew - Arabic) on the Run Options on Xcode.
  • Open a new empty post.
    • Check that the Title and inserter placeholders are visible.
    • Check that the fields are selectable and you can type on them.
    • Check that longer text makes the text area increase in height as expected.
  • Make the same checks from ⬆️ on a LTR language.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@etoledom etoledom mentioned this pull request Aug 12, 2020
Closed
3 tasks
@etoledom etoledom requested a review from guarani August 12, 2020 07:44
@etoledom etoledom added this to the 1.35 milestone Aug 12, 2020
@etoledom etoledom mentioned this pull request Aug 12, 2020
Merged
6 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 12, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@etoledom etoledom marked this pull request as ready for review August 12, 2020 07:54
guarani
guarani approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via wordpress-mobile/WordPress-iOS#14630 (review)

@etoledom etoledom force-pushed the fix-RTL-lang-empty-rich-text branch from f1bc780 to f393db0 Compare August 14, 2020 09:02
@ceyhun
Copy link
Contributor

ceyhun commented Aug 14, 2020

@etoledom heads up we'll be cutting the 1.35 release branch beginning of next week. Please try to get this merged by then or bump the milestone 🙇

@etoledom etoledom self-assigned this Aug 14, 2020
@etoledom etoledom merged commit b7fb979 into develop Aug 14, 2020
@etoledom etoledom deleted the fix-RTL-lang-empty-rich-text branch August 14, 2020 11:41
@cameronvoell cameronvoell mentioned this pull request Aug 18, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guarani guarani guarani approved these changes

Assignees

@etoledom etoledom

Labels
[OS] iOS RTL
Projects
None yet
Milestone
1.35
Development

Successfully merging this pull request may close these issues.
3 participants
@etoledom @ceyhun @guarani