Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover: Add Background Media button when only background colour is set #2513

Merged
merged 3 commits into from
Jul 28, 2020
Merged

Cover: Add Background Media button when only background colour is set #2513

merged 3 commits into from
Jul 28, 2020

Conversation

antonis
Copy link

@antonis antonis commented Jul 27, 2020

Fixes WordPress/gutenberg#23877 (parent #2275)

Description

Please check gutenberg PR WordPress/gutenberg#23878

To test:

  • Add a cover block
  • Press on a colour from the palette
  • Verify that a new cover block with only colour is created
  • Verify that the new icon is presented at the top-left of the component
  • Tap on the icon and verify that the add media options are presented
  • Add a media and verify that it is applied in the background

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to [RELEASE-NOTES.txt](RELEASE-NOTES.txt) if necessary.

@antonis antonis added this to the 1.34 milestone Jul 27, 2020
@antonis antonis added [Type] Enhancement Improves a current area of the editor Blocks labels Jul 27, 2020
@antonis antonis mentioned this pull request Jul 27, 2020
Merged
6 tasks
@antonis antonis requested a review from mkevins July 27, 2020 08:15
@antonis antonis mentioned this pull request Jul 27, 2020
Closed
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 28, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

mkevins
mkevins approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#23878 (review)

Nice work Antonis!

@antonis antonis merged commit fde49d6 into develop Jul 28, 2020
@antonis antonis deleted the issue/CoverAddImageButton branch July 28, 2020 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkevins mkevins mkevins approved these changes

Assignees
No one assigned
Labels
Blocks [Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
1.34
Development

Successfully merging this pull request may close these issues.
2 participants
@antonis @mkevins