Gallery - Media editing #2496
Merged
Gallery - Media editing #2496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 21, 2020
geriux
force-pushed
the
feature/gallery-media-editing
branch
from
10f352d to
ad8e1c6
Compare
|
👋 @geriux ! We're getting ready to cut the 1.34 release branch, so I'm bumping this to the 1.35 milestone. If this needs to make the 1.35 release though, go ahead and change the milestone back and try to get this merged as soon as possible. If you're trying to get this into the release, please also let us know in Slack. 🙇 |
added 2 commits
August 5, 2020 18:40
# Conflicts: # gutenberg
geriux
force-pushed
the
feature/gallery-media-editing
branch
from
ad8e1c6 to
6efaf03
Compare
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
geriux
force-pushed
the
feature/gallery-media-editing
branch
from
6efaf03 to
00a6b00
Compare
geriux
force-pushed
the
feature/gallery-media-editing
branch
from
00a6b00 to
4fd1280
Compare
geriux
force-pushed
the
feature/gallery-media-editing
branch
from
4fd1280 to
13ad7de
Compare
geriux
force-pushed
the
feature/gallery-media-editing
branch
from
13ad7de to
b5599e8
Compare
# Conflicts: # gutenberg
geriux
force-pushed
the
feature/gallery-media-editing
branch
from
b5599e8 to
85b0b6e
Compare
|
Hey @lukewalczak 👋 since you already approved the Gutenberg PR, can you please approve this one as well? Thanks! |
lukewalczak
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2389
Gutenberg PR-> WordPress/gutenberg#24088WordPress iOS PR-> wordpress-mobile/WordPress-iOS#14498WordPress Android PR-> wordpress-mobile/WordPress-Android#12497Continuing adding media editing support to blocks, this PR adds it to Gallery block. For a more detailed description and testing plan check the
GutenbergPR description.PR submission checklist:
[RELEASE-NOTES.txt](RELEASE-NOTES.txt)if necessary.