Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover: Adds Clear media button in block settings #2489

Merged
merged 3 commits into from
Jul 17, 2020

Conversation

antonis
Copy link

@antonis antonis commented Jul 16, 2020

Fixes WordPress/gutenberg#23789 (parent #2275)

Related PRs:

Description

Adds Clear media button in block settings

How has this been tested?

  • Add a cover block
  • Press the ADD IMAGE OR VIDEO button and select a media
  • Tap on the block settings
  • Verify that there is a clear media button that removes the set image

Screenshots

With set media Without set media
Simulator Screen Shot - iPhone 11 - 2020-07-16 at 09 47 31 Simulator Screen Shot - iPhone 11 - 2020-07-08 at 18 23 14

Types of changes

Enhancement

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to [RELEASE-NOTES.txt](RELEASE-NOTES.txt) if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 16, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonis antonis merged commit e5eb4aa into develop Jul 17, 2020
@antonis antonis deleted the issue/23789_Cover_Clear_Media branch July 17, 2020 09:21
@antonis antonis added this to the 1.33 milestone Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocks [Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants