Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Page Template picker if modal layout picker is available #2478

Merged
merged 4 commits into from
Jul 15, 2020

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Jul 10, 2020

Fixes: #2419

Related PRs:

Description

This change enables the mobile editor to accept the capability modalLayoutPicker and based on that conditionally show or hide the Template Picker.

Opening this PR to generate a bundle so that the toggle in iOS is testable.

How has this been tested?

To disable or enable the development version of Modal Layout Picker

On iOS using the build options mentioned above

  • With Gutenberg Modal Layout Picker toggled on:

    • Select to create a new page
    • Expect to see the container for the new modal Layout Picker
    • Select "Create Blank Page"
    • Expect the current template picker to be hidden
  • With Gutenberg Modal Layout Picker toggled on:

    • Select an existing page or draft without content (just a title)
    • You should not see the new Modal Layout Picker
    • Expect the current template picker to be hidden
  • With Gutenberg Modal Layout Picker toggled off:

    • Select to create a new page
    • You should not see the new Modal Layout Picker
    • Expect the current template picker to be shown.
  • With Gutenberg Modal Layout Picker toggled off:

    • Select an existing page or draft without content (just a title)
    • You should not see the new Modal Layout Picker
    • Expect the current template picker to be shown
  • With Gutenberg Modal Layout Picker toggled on or off:

    • Select an existing page or draft with content
    • Expect the current template picker to be hidden

On Android running a metro server or generating a build

  • Existing Blank Page
    • Select an existing page or draft without content (just a title)
    • Expect the current template picker to be shown
  • New Page
    • Select to create a new page
    • Expect the current template picker to be shown.
  • Existing Page
    • Select an existing page or draft with content
    • Expect the current template picker to be hidden

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to [RELEASE-NOTES.txt](RELEASE-NOTES.txt) if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 10, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@chipsnyder chipsnyder changed the title Update gutenberg reference Disable Page Template picker if modal layout picker is available Jul 10, 2020
@chipsnyder chipsnyder requested a review from geriux July 10, 2020 17:16
@chipsnyder chipsnyder marked this pull request as ready for review July 10, 2020 17:34
@chipsnyder
Copy link
Contributor Author

chipsnyder commented Jul 10, 2020

The iOS PR is still in design review but this can be reviewed and merged separately from that.

Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chipsnyder
Copy link
Contributor Author

There seems to be a sync issue here as the PR isn't showing the merge commit. Closing and reopening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Modal Layout Picker] Create Modal window for Modal Layout Picker
2 participants