Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert - add selectionStart and selectionEnd to transientEdits #2353

Merged
merged 2 commits into from
Jun 5, 2020

Conversation

dratwas
Copy link
Contributor

@dratwas dratwas commented Jun 5, 2020

Fixes #2349
This PR reverts commit that introduced regression in the client app.

Gutenberg PR: WordPress/gutenberg#22933

To test:

  • Run WP-iOS app

  • type something really fast and press publish

  • the correct version should be published

  • type something in the paragraph

  • the undo level should be created after each sign

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 5, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mchowning mchowning merged commit c23a7ef into develop Jun 5, 2020
@mchowning mchowning deleted the fix/revert-undo-levels branch June 5, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autosave stops working when typing fast
2 participants