Remove Keyboard.dismiss when deleting block #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
6 tasks
mchowning
approved these changes
May 27, 2020
There was a problem hiding this comment.
Thanks @lukewalczak 👍
Once these are merged we can cherry-pick the gutenberg commit over to the gutenberg rnmobile/release-1.29.0 branch and then update the submodule ref on the gutenberg-mobile release/1.29.0 branch. I can take care of that if you want to ping me when these are merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can fix: wordpress-mobile/WordPress-Android#10491
Ref to gutenberg: WordPress/gutenberg#22677
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.