Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest gutenberg #2317

Merged
merged 3 commits into from
May 26, 2020
Merged

Update to latest gutenberg #2317

merged 3 commits into from
May 26, 2020

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented May 26, 2020 •
edited
Loading

Also re-enables the list spaces e2e test, which should now pass with the latest gutenberg code merged in.

Before merging this we need to update the gutenberg submodule ref to the gb master hash after WordPress/gutenberg#22607 is merged.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@mchowning mchowning added this to the 1.29 milestone May 26, 2020
@mchowning mchowning requested a review from SergioEstevao May 26, 2020 13:42
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 26, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@mchowning mchowning force-pushed the update_to_latest_gutenberg branch from fa1d7c7 to bff2e1a Compare May 26, 2020 14:06
SergioEstevao
SergioEstevao approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great!

@mchowning mchowning merged commit 486acca into develop May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.29
Development

Successfully merging this pull request may close these issues.
2 participants
@mchowning @SergioEstevao