Fix page templates button alignment and strings #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
6 tasks
geriux
approved these changes
May 26, 2020
|
Thank you again for testing / reviewing Gerardo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2287 #2295 #2267
Related PR:
gutenberg: WordPress/gutenberg#22620Description
This PR fixes some strings in the mobile pages templates to be consistent, and also uses center alignment for the buttons.
To test:
In a new page, apply each of the templates and verify that the buttons are center aligned, and that the following strings are consistent "Let's build something together!" (should have an exclamation mark at the end), and "Get in Touch" (consistently title case for each instance).
PR submission checklist:
RELEASE-NOTES.txtif necessary.