-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Slider to reflect changes immediately #2286
Conversation
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
d6014c3
to
dc0324c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved via WordPress/gutenberg#22421 (review)
Just one thing about the release notes.
507f5f3
to
b0f9d27
Compare
We're preparing to cut the 1.30 release branches now. Let's merge this ASAP or update the milestone to 1.31. |
Hey @mchowning, unfortunately, we had to revert the PR that fixed the issue with creating undo levels when using the slider. WordPress/gutenberg#22933 The issue is described here #2192 (comment) I'm moving it to the milestone 1.31 |
👋 @dratwas! We're close to merging the monorepo changes 🎉 , and we will be cutting the release branches as soon as the monorepo changes are merged to gutenberg-mobile. As a result, we may be cutting the 1.31 release branches earlier than normal. Because every merge further delays the monorepo work (ends up requiring conflicts to be fixed and other work due to the monorepo feature branch and the squash policy in gutenberg), we want to cut the release branch with no further changes. For that reason, I'll bump this milestone to 1.32. Of course, if this has to make the 1.31 release, go ahead and move it back to the 1.31 milestone, and let me know. 🙇 |
👋 @dratwas ! We're getting ready to cut the 1.32 release branch, so I'm bumping this to the 1.33 milestone. If this needs to make the 1.32 release though, go ahead and change the milestone back and try to get this merged as soon as possible. If you're trying to get this into the release, please also let us know in Slack. 🙇 |
Hey @mchowning thanks for the heads up i need to wait for the wordpress-mobile/WordPress-Android#12144 with this one. |
👋 @dratwas ! We're getting ready to cut the 1.33 release branch, so I'm bumping this to the 1.34 milestone. If this needs to make the 1.33 release though, go ahead and change the milestone back and try to get this merged as soon as possible. If you're trying to get this into the release, please also let us know in Slack. 🙇 |
👋 @dratwas ! We're getting ready to cut the 1.34 release branch, so I'm bumping this to the 1.35 milestone. If this needs to make the 1.35 release though, go ahead and change the milestone back and try to get this merged as soon as possible. If you're trying to get this into the release, please also let us know in Slack. 🙇 |
b0f9d27
to
417414b
Compare
@dratwas heads up we'll be cutting the 1.35 release branch beginning of next week. Please try to get this merged by than or bump the milestone 🙇 |
Bumping milestone |
cd6ebcc
to
794bba5
Compare
@dratwas not sure if this PR is needed for package.json updates, or if we can close it since I believe the gutenberg side is already merged and updated in gb-mobile develop. If you want to merge this one, I think merging in develop should fix CI (fix PR - #2571). I'll cut the branches for 1.36 later in the day on Monday 8/31, see please merge before then if needed, thanks! |
Closing since these changes are merged already. |
Fixes #2192
Gutenberg PR: WordPress/gutenberg#22421
To test:
1.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.