Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radial gradient infrastructure #2277

Merged
merged 8 commits into from
Jun 17, 2020
Merged

Conversation

lukewalczak
Copy link
Contributor

Fixes #

Ref to gtuenberg: WordPress/gutenberg#22493
To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 26, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux
Copy link
Contributor

geriux commented Jun 3, 2020

Hey @lukewalczak 👋 this is still marked as a draft, is it ready to be reviewed?

@lukewalczak
Copy link
Contributor Author

Yes, forgot to change it. Gutenberg PR is already open.

@lukewalczak lukewalczak marked this pull request as ready for review June 3, 2020 07:11
@lukewalczak lukewalczak force-pushed the radial_gradient_infrastructure branch from 62b4d3e to 13091ad Compare June 3, 2020 07:28
@geriux geriux self-requested a review June 11, 2020 12:33
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved via WordPress/gutenberg#22493 (review)

Let's update the Gutenberg ref and the changelog =)

@geriux geriux added this to the 1.31 milestone Jun 11, 2020
@geriux geriux added the [Type] Enhancement Improves a current area of the editor label Jun 11, 2020
@lukewalczak lukewalczak merged commit 342f224 into develop Jun 17, 2020
@lukewalczak lukewalczak deleted the radial_gradient_infrastructure branch June 17, 2020 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants