Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve react native version from package.json #2248

Merged
merged 7 commits into from
May 22, 2020

Conversation

trackq
Copy link
Contributor

@trackq trackq commented May 9, 2020

Fixes a 'FIXME' found in the code without an issue.

Making sure no conflicts arise when a new react-native version is used in package.json, but forgotten to update the hardcoded reference.

Refactored code to remove an external dependencies. Added function to read version number.

To test:

  • CI is green
  • Run yarn test:e2e:android:local

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

trackq added 4 commits May 9, 2020 13:49
This makes range parameter (+) obsolete.
Removed duplicate functionality from an extranal host.
Use local source via range parameter if we are not on Jitpack
@trackq trackq changed the title Retrieve react native version from package.json WIP: Retrieve react native version from package.json May 9, 2020
Checking to see if CI goes green.
@trackq
Copy link
Contributor Author

trackq commented May 11, 2020

Just to make sure I wasn't doing something obviously wrong, I reverted the file back to the original contents. But the build is still failing.

Now we at least no it's not changes.

@mchowning
Copy link
Contributor

mchowning commented May 18, 2020

👋 @trackq ! Thanks for the PR! I believe the tests are failing because CI doesn't currently handle PRs from forks very well. If you would revert 2932bdb so we have your changes are back, I'll take a look and see what I can do.

@trackq
Copy link
Contributor Author

trackq commented May 19, 2020

👍 Let me know if I can help

@mchowning
Copy link
Contributor

mchowning commented May 20, 2020

Would you go ahead and revert 2932bdb so we have your changes back @trackq (or you could add a new commit re-adding your changes)? 🙇

@trackq
Copy link
Contributor Author

trackq commented May 21, 2020

🙈 I misread that part @mchowning.

Done. ✌️

@mchowning mchowning mentioned this pull request May 21, 2020
@mchowning
Copy link
Contributor

mchowning commented May 21, 2020

Thanks @trackq! Could you also merge in the latest changes from develop? There have been some updates to the CI setup that we need on this branch.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 22, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@trackq
Copy link
Contributor Author

trackq commented May 22, 2020

@mchowning good like this?

Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally got CI straightened out! 🎉

These changes look good to me. Thanks so much for contributing @trackq ! This does a nice job of keeping the RN version in react-native-aztec consistent with the version in the root package.json. If you think these changes are ready and want to change this PR from being a "Draft" so it is ready to review, I think we can merge this. I'd switch it myself, but I just wanted to make sure you didn't still have it as a draft because you wanted to make any more changes.

@trackq trackq changed the title WIP: Retrieve react native version from package.json Retrieve react native version from package.json May 22, 2020
@trackq trackq marked this pull request as ready for review May 22, 2020 13:01
@trackq
Copy link
Contributor Author

trackq commented May 22, 2020

🥳

Send it. Thanks for the help!

Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trackq ! :shipit:

@mchowning mchowning merged commit d95255a into wordpress-mobile:develop May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants