-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrieve react native version from package.json #2248
Retrieve react native version from package.json #2248
Conversation
This makes range parameter (+) obsolete.
Removed duplicate functionality from an extranal host.
Use local source via range parameter if we are not on Jitpack
Checking to see if CI goes green.
Just to make sure I wasn't doing something obviously wrong, I reverted the file back to the original contents. But the build is still failing. Now we at least no it's not changes. |
👍 Let me know if I can help |
🙈 I misread that part @mchowning. Done. ✌️ |
Thanks @trackq! Could you also merge in the latest changes from |
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
@mchowning good like this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally got CI straightened out! 🎉
These changes look good to me. Thanks so much for contributing @trackq ! This does a nice job of keeping the RN version in react-native-aztec
consistent with the version in the root package.json. If you think these changes are ready and want to change this PR from being a "Draft" so it is ready to review, I think we can merge this. I'd switch it myself, but I just wanted to make sure you didn't still have it as a draft because you wanted to make any more changes.
🥳 Send it. Thanks for the help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @trackq !
Fixes a 'FIXME' found in the code without an issue.
Making sure no conflicts arise when a new react-native version is used in package.json, but forgotten to update the hardcoded reference.
Refactored code to remove an external dependencies. Added function to read version number.
To test:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.