Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: remove override support inserter for columns block #2221

Merged
merged 3 commits into from
May 13, 2020
Merged

Refactor: remove override support inserter for columns block #2221

merged 3 commits into from
May 13, 2020

Conversation

jbinda
Copy link
Contributor

@jbinda jbinda commented May 6, 2020 •
edited
Loading

This PR removes temporary support: inserter overrides for Columns block.

See this PR for more details

To test:

  • check if its possible to add Column in Columns block via Inserter

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jbinda jbinda requested a review from pinarol May 6, 2020 11:23
@jbinda jbinda self-assigned this May 6, 2020
@jbinda jbinda added the Blocks label May 6, 2020
@jbinda jbinda mentioned this pull request May 6, 2020
Merged
6 tasks
pinarol
pinarol approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbinda jbinda merged commit efe0087 into develop May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

Assignees

@jbinda jbinda

Labels
Blocks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbinda @pinarol