Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow shrink mobile toolbar #2220

Merged
merged 7 commits into from
May 22, 2020
Merged

Allow shrink mobile toolbar #2220

merged 7 commits into from
May 22, 2020

Conversation

lukewalczak
Copy link
Contributor

@lukewalczak lukewalczak commented May 6, 2020

Fixes #2180

Ref to gutenberg: WordPress/gutenberg#22132
Ref to WordPress-IOS: wordpress-mobile/WordPress-iOS#14062
Ref to testing ios: wordpress-mobile/WordPress-iOS#14073

NOTE: That PR is adding a patch to RN since currently there is no option for disabling buttons within action sheet ios. PR in RN is waiting to be approved and merge.

To test:

  1. Open mobile app
  2. Add Buttons block
  3. Focus Button block inside Buttons block
  4. Expect to see stacked options in the mobile toolbar
  5. Press button in the mobile toolbar
  6. Expect the disabled button Move Left for the first button
  7. Expect the disabled button Move Right for the last button
  8. Try all the options:
    • expect Button is moving left/right when these options are available
    • expect to be able to open settings
    • expect to be able to remove block

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dratwas
Copy link
Contributor

dratwas commented May 19, 2020

Hey @lukewalczak I think that this PR needs a release note :)

@geriux geriux self-requested a review May 22, 2020 10:41
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved via WordPress/gutenberg#22132 (review)

Let's remove the bundles and update the release notes.

@lukewalczak lukewalczak force-pushed the allow-shrink-mobile branch from 5e4f147 to 2fdc03d Compare May 22, 2020 11:22
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 22, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@lukewalczak lukewalczak merged commit d57c647 into develop May 22, 2020
@lukewalczak lukewalczak deleted the allow-shrink-mobile branch May 22, 2020 14:13
@mchowning mchowning mentioned this pull request May 26, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow shrinking the block toolbar for small blocks
3 participants