Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: move scrollEnabled to BlockList #2145

Merged
merged 5 commits into from
Apr 20, 2020
Merged

Refactor: move scrollEnabled to BlockList #2145

merged 5 commits into from
Apr 20, 2020

Conversation

jbinda
Copy link
Contributor

@jbinda jbinda commented Apr 9, 2020 •
edited
Loading

Fixes #2130

This PR moves calculation of scrollEnabled prop to BLockList instead of passing it from blocks.

Please also refer to:
Related gutenberg PR
Related gutenberg-mobile issue

To test:

  • - expect only RootList is scrollable
  • - expect none of InnerBlock is not scrollable
  • - check if there is no block with exception about above

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jbinda jbinda requested review from Tug, geriux and pinarol April 9, 2020 14:06
@jbinda jbinda self-assigned this Apr 9, 2020
@jbinda jbinda mentioned this pull request Apr 9, 2020
Merged
6 tasks
@pinarol pinarol removed their request for review April 20, 2020 09:19
pinarol
pinarol approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbinda jbinda merged commit e7e6cce into develop Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

@Tug Tug Awaiting requested review from Tug

@geriux geriux Awaiting requested review from geriux

Assignees

@jbinda jbinda

Labels
Blocks InnerBlocks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider move scrollEnabled prop to BlockList
2 participants
@jbinda @pinarol